Date: Tue, 28 Feb 2017 23:16:53 -0800 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: "Rodney W. Grimes" <freebsd-rwg@pdx.rh.CN85.dnsmgr.net> Cc: Ngie Cooper <ngie@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r314464 - head/usr.sbin/yppush Message-ID: <04EB01C9-6115-44A3-89EB-A8ED37A107E5@gmail.com> In-Reply-To: <201703010553.v215rfIj054071@pdx.rh.CN85.dnsmgr.net> References: <201703010553.v215rfIj054071@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
> On Feb 28, 2017, at 21:53, Rodney W. Grimes <freebsd-rwg@pdx.rh.CN85.dnsmgr.net> wrote:
>
> -- Start of PGP signed section.
> [ Charset UTF-8 unsupported, converting... ]
>>
>>> On Feb 28, 2017, at 21:38, Rodney W. Grimes <freebsd-rwg@pdx.rh.CN85.dnsmgr.net> wrote:
>>>
>>> Would it be possible to not do this as 1000 commits?
>>
>> Yes, but I?m trying to do this in a way that allows me to backport all of the changes as easily as possible to ^/stable/10 (on the other side of the coin, I?ve run into dependent commits of other MFCs that required sweeping changes in order to make my changes possible).
>> I do think your point is valid though and I can probably strike some middle ground with my changes. I think grouping it up by 2nd level directory (like I did with usr.bin/svn) makes the most sense.
>> Thank you,
>
> Yes, that is what I was thinking. Note that I dont agree with this change,
> but I have probably missed a discussion that is allowing it to move forward.
> It makes the logfiles of make output now src tree possition dependent,
> but I am probalby the only person in the universe that has ever run a
> diff on the output of make world.
It was much the same way before, i.e. .CURDIR was a full path. My doing this achieves what you described, it helps dumb tools (like Jenkins) dedupe warnings though, and it also makes it easier to fork/build on different components in the source tree (I recently embarked on joining a forked copy of syslogd at $work, and using SRCTOP helps me achieve that, in the sense that I don’t need to duplicate Makefiles).
> It may also be possible to split this into some phases to reduce some of
> your issues, only do the {.CURDIR}/../../foo -> ${SRCTOP}/bar/foo in one pass and
> some of the other fixes in another pass.
Yeah. That seems reasonable (I will split it up into larger chunks).
Thanks,
-Ngie
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org
iQIcBAEBCgAGBQJYtnVlAAoJEPWDqSZpMIYVjYEP/1v8c2BjppCdqW0S2avqi3t+
xVbROW5JCL0vRTfizl33T9+Ztcec2LuYTnNaoqmSyHSLa6dO0Wov0MTmxm3Mr6zG
v102d1FKEO/f002dBprsWYIftHNEtDmN/K1WD+cHsxf156yUERm/2yKb8aeWs7yv
fo2Q4lxI/z0yycdcAl6vmHWu7Bp4aloMPqEErDApEWLqlQxJgWcD96vetdf/iaq2
yF9PvHtaFnuOBE/a6KkDHLcayRk77YTEzvErJ69o1RaMrMxc+VY+htnMbhvs4Isx
1kLWBv5L2Eu7PkyH1Rf7kURtyj+htzkS1DoS8FJzAoUARsisBaQdjjyRqEJ+A3bn
G/yyiKIRi1mw687abZOJ30aXm2Qm+l8ruUaz/Cn4s/NJpEl355blQlllqiLKtszz
XSv8DyIe+JSvRs/EBRaeW3rQ59X8ppep2+3D4TzWpWNjGJbx1/HvPq87DhfIn0Hs
nZxTmDxobTNfLMEoPR1xWXBy2rr68s8HsiN7Rw3dP7MTIGOsgDDquSrGlXBBJq+L
GO/c1zhV1KxH2oHGioiSYrM4lmWl31PP43fFpUAWv68WzM00D4n1JbATJ6p3UztZ
GaqHvfgaMfpMT7QQwvOA031go1P/xx2nX6jLqYroxizoKpcrGTzbp040POP7KxMh
a8hhg6MQeW40O1086n0i
=E2aP
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?04EB01C9-6115-44A3-89EB-A8ED37A107E5>