Date: Mon, 1 Nov 2021 19:44:31 +0100
From: Tobias Kortkamp <tobik@freebsd.org>
To: Yasuhiro Kimura <yasu@freebsd.org>
Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject: Re: git: d356121270d7 - main - mail/postfix{,-ldap-sasl,-sasl}: Flavorize
Message-ID: <YYA1j9FOjGd6vxz0@loki.kortkamp.xyz>
In-Reply-To: <202110280007.19S07MMW076891@gitrepo.freebsd.org>
References: <202110280007.19S07MMW076891@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--g5ZxA2BwedQK2K0v
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Thu, Oct 28, 2021 at 12:07:22AM +0000, Yasuhiro Kimura wrote:
> -POSTFIX_CCARGS+=3D -DDEF_CONFIG_DIR=3D\\\"${ETCDIR}\\\" \
> - -DDEF_DAEMON_DIR=3D\\\"${DAEMONDIR}\\\" \
> - -DDEF_META_DIR=3D\\\"${META_DIRECTORY}\\\" \
> - -DDEF_COMMAND_DIR=3D\\\"${PREFIX}/sbin\\\" \
> - -DDEF_SENDMAIL_PATH=3D\\\"${PREFIX}/sbin/sendmail\\\" \
> - -DDEF_NEWALIAS_PATH=3D\\\"${PREFIX}/bin/newaliases\\\" \
> - -DDEF_MAILQ_PATH=3D\\\"${PREFIX}/bin/mailq\\\" \
> - -DDEF_MANPAGE_DIR=3D\\\"${MANPREFIX}/man\\\" \
> - -DDEF_README_DIR=3D\\\"${READMEDIR}\\\" \
> - -DDEF_HTML_DIR=3D\\\"${READMEDIR}\\\" \
> - -DDEF_QUEUE_DIR=3D\\\"/var/spool/postfix\\\" \
> - -DDEF_DATA_DIR=3D\\\"/var/db/postfix\\\" \
> - -DDEF_MAIL_OWNER=3D\\\"postfix\\\" \
> - -DDEF_SGID_GROUP=3D\\\"maildrop\\\" \
> - -Wmissing-prototypes -Wformat -Wno-comment
> +POSTFIX_CCARGS+=3D -DDEF_CONFIG_DIR=3D\\\"${ETCDIR}\\\" -DDEF_DAEMON_DIR=
=3D\\\"${DAEMONDIR}\\\" -DDEF_META_DIR=3D\\\"${META_DIRECTORY}\\\" -DDEF_CO=
MMAND_DIR=3D\\\"${PREFIX}/sbin\\\" -DDEF_SENDMAIL_PATH=3D\\\"${PREFIX}/sbin=
/sendmail\\\" -DDEF_NEWALIAS_PATH=3D\\\"${PREFIX}/bin/newaliases\\\" -DDEF_=
MAILQ_PATH=3D\\\"${PREFIX}/bin/mailq\\\" -DDEF_MANPAGE_DIR=3D\\\"${MANPREFI=
X}/man\\\" -DDEF_README_DIR=3D\\\"${READMEDIR}\\\" -DDEF_HTML_DIR=3D\\\"${R=
EADMEDIR}\\\" -DDEF_QUEUE_DIR=3D\\\"/var/spool/postfix\\\" -DDEF_DATA_DIR=
=3D\\\"/var/db/postfix\\\" -DDEF_MAIL_OWNER=3D\\\"postfix\\\" -DDEF_SGID_GR=
OUP=3D\\\"maildrop\\\" -Wmissing-prototypes -Wformat -Wno-comment
Hi,
this is caused by a tokenizer bug in portfmt where it treated
the entire thing as one word. It is not ok for portfmt to format
POSTFIX_CCARGS like that. I fixed it in [0].
Sorry, I saw it in the review earlier but forgot to comment on
it. Please report stuff like this to me on GitHub [1] or on
Bugzilla.
Thanks!
[0] https://github.com/t6/portfmt/commit/001ba6fa4b0f1f5b5e4dfd913564dc5641=
8d0a36
[1] https://github.com/t6/portfmt/issues=20
--g5ZxA2BwedQK2K0v
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQGTBAEBCgB9FiEElXvTEJc6ePgdQuobpPCftzzFH2EFAmGANY1fFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk1
N0JEMzEwOTczQTc4RjgxRDQyRUExQkE0RjA5RkI3M0NDNTFGNjEACgkQpPCftzzF
H2FzbwgAn0ugCUPf38EgNR3q07vPTZmFb/WJFmnAWljwrfsA+e4vIyNpl4oawRgi
e4jBYonwU6plPJ8s7U8fTG2jFwkZMvdXdvbE1ZdjIPA7X3PGisg8RzfOqw4jRdTg
+t58u/VfpcxNtlYCTMr9EgdEDiKl66tNZWeQAvR8cF3yptc3wCN51iNVWPDvF7E9
uXptlDtVEcoGj70AtHmygVXSWTjkL3KsHgLHNFvx3FSFRFDI43527TqS0EOgenck
SYq3JJ4yI8VLJetf0naBsUiEm4/kfn+US2csAHtclHQLdUNGH2auCgIB/lImFoee
6pdZWa9gxAcREmOJzt0bHKv9rpwppA==
=LZQu
-----END PGP SIGNATURE-----
--g5ZxA2BwedQK2K0v--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YYA1j9FOjGd6vxz0>