Date: Thu, 29 Nov 2018 10:34:37 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 212097] [NEW PORT] www/apt-cacher-ng: Caching proxy for software distribution sites port (includes FreeBSD customization) Message-ID: <bug-212097-7788-5FnlwbGyMf@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-212097-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-212097-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D212097 Tobias Kortkamp <tobik@freebsd.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|ports-bugs@FreeBSD.org |tobik@freebsd.org --- Comment #7 from Tobias Kortkamp <tobik@freebsd.org> --- ould you order the variables according to [1]?=20 XThis is a port of apt-cacher-ng, a caching http/s proxy specialized in Never start pkg-descr with "This is a port". How about starting with "apt-cacher-ng is a caching ..." instead? There are also some typos in pkg-descr. XMore details are on the original projects web page. I think this sentence is superfluous and could be dropped. It's pretty much why pkg-descr always ends with WWW. XOPTIONS_DEFAULT=3D SSL DOCS DOCS is always enabled by default, so it doesn't need to be here. X#SSL_BUILD_DEPENDS=3D pkg-config:devel/pkgconf X#SSL_BUILD_DEPENDS=3D pkg-config:devel/pkgconf openssl:security/openssl X#SSL_LIB_DEPENDS=3D libcrypto.so:security/openssl Please remove all the commented out variables. Especially these very wrong bits. XSSL_DESC=3D Include SSL support to allow proxying https sites. Remove the dot at the end. XFUSE_DESC=3D Include FUSE support. FUSE already has a better common description. What does the option do in the context of the port (maybe mention acngfs)? XDISTNAME=3D ${PORTNAME}_${PORTVERSION}.orig You can eliminate setting WRKSRC below if you use DISTFILES=3D ${PORTNAME}_${PORTVERSION}.orig${EXTRACT_SUFX} instead here. Xpost-stage: Use post-install X ${INSTALL_MAN} ${WRKSRC}/COPYING ${STAGEDIR}${DOCSDIR} X ${INSTALL_MAN} ${WRKSRC}/ChangeLog ${STAGEDIR}${DOCSDIR} X ${INSTALL_MAN} ${WRKSRC}/TODO ${STAGEDIR}${DOCSDIR} Use INSTALL_DATA to install documentation. COPYING is already installed via LICENSE_FILE. No need to install it twice. Does the ChangeLog and TODO really contain useful information for users? X ${INSTALL_MAN} ${WRKDIR}/Readme.FreeBSD ${STAGEDIR}${DOCSDIR} I think this should be a pkg-message instead, so that users see it after installation. [1] https://www.freebsd.org/doc/en/books/porters-handbook/porting-order.html --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-212097-7788-5FnlwbGyMf>