Date: Tue, 13 Jun 2023 13:28:17 +0700 From: Eugene Grosbein <eugen@freebsd.org> To: Gleb Popov <arrowd@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: f89fd0980a5c - main - databases/mysql57-client: be ready for OpenSSL 3.0 in base Message-ID: <4c244417-9439-dbb0-beea-75ed7672b869@freebsd.org> In-Reply-To: <CALH631mHS1RB5PzgkO3fn5TSXcuT2=Z19pNkWO-y8YD3rVSsOA@mail.gmail.com> References: <202306130516.35D5GXM1015646@gitrepo.freebsd.org> <CALH631mHS1RB5PzgkO3fn5TSXcuT2=Z19pNkWO-y8YD3rVSsOA@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
13.06.2023 13:05, Gleb Popov wrote:
> On Tue, Jun 13, 2023 at 8:16 AM Eugene Grosbein <eugen@freebsd.org> wrote:
>>
>> IF(OPENSSL_INCLUDE_DIR)
>> ++ FOREACH(version_part
>> ++ OPENSSL_VERSION_MAJOR
>> ++ OPENSSL_VERSION_MINOR
>> ++ OPENSSL_VERSION_PATCH
>> ++ )
>> ++ FILE(STRINGS "${OPENSSL_INCLUDE_DIR}/openssl/opensslv.h" ${version_part}
>
> I don't quite see how it is supposed to work. The result of the
> "file(STRINGS ...)" call overwrites your loop variable.
>
> Anyways, more canonical way to solve this is
> https://cmake.org/cmake/help/latest/module/CheckSymbolExists.html
That's not my code. I just got it from MySQL 8.0 distribution file and tested.
And it works for both cases of OpenSSL 3.0 in base and OpenSSL 1.1.1 in base.
home |
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4c244417-9439-dbb0-beea-75ed7672b869>