Date: Mon, 21 Oct 2019 16:05:18 +0000 From: Glen Barber <gjb@freebsd.org> To: Dimitry Andric <dim@freebsd.org> Cc: Jeremy <jeremy.m.cox@gmail.com>, freebsd-stable stable <freebsd-stable@freebsd.org> Subject: Re: Is it necessary to bump target triple for lib32 Message-ID: <20191021160518.GA1430@FreeBSD.org> In-Reply-To: <F42A3DE1-A46F-4440-A7EC-2C66BAFE14ED@FreeBSD.org> References: <CAPH9q1r%2BDChJtGxpt-QzDBd4hsRBiiwt0ie5DR4-uWkP_=AFoA@mail.gmail.com> <F42A3DE1-A46F-4440-A7EC-2C66BAFE14ED@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Sun, Oct 20, 2019 at 12:39:29AM +0200, Dimitry Andric wrote: > On 19 Oct 2019, at 05:51, Jeremy <jeremy.m.cox@gmail.com> wrote: > > > > While I was doing a buildworld for FreeBSD 12 stable (r353745) for amd64, I > > noticed the target triple was set at x86_64-unknown-freebsd12.0 while it > > was building the 32 bit libraries. I was wondering if it was necessary to > > bump it to 12.1 now that 12.1 is getting ready for release, or if it > > doesn't matter either way. I believe the relevant commit was from > > (r338268). In any case, buildworld completed with no issues. > > > > If it's not necessary, sorry for the noise. > > You are right, this is coming from Makefile.libcompat: > > $ grep freebsd12 Makefile.libcompat > LIB32CPUFLAGS+= -target x86_64-unknown-freebsd12.0 > LIB32CPUFLAGS= -target mipsel-unknown-freebsd12.0 > LIB32CPUFLAGS= -target mips-unknown-freebsd12.0 > > Glen, I think you have a list somewhere of the files that need to have > their versions bumped for releng branches, could you please add > Makefile.libcompat to it too? > Yes, I will add it to the doc now. I thought it was there already, but apparently not. > Maybe at one point we should have one source of truth for that obtaining > that version number... :) > We do have one. % make -C release -V REVISION 12.1 Glen [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEjRJAPC5sqwhs9k2jAxRYpUeP4pMFAl2t1zoACgkQAxRYpUeP 4pNyHg/9Eh7i62F1I3I87dhRihAzK4LM/rq9Yc4mEwLctmn7neCP/DKgkR2bBeXY YgH420OjFCOYaRD6wSv3XPCYyB4zTQdrRhQvKjLmoB0HAR3J6JOBjoTNvN2eSLMN QfmwUV5oHWNgZuhPjUjOmlKW+v4WKApYJROswDRk8bI3EGudWg6vwJgtauAr0lyf eyBujYaEVIpof2vfJV7JPi+ND2KiyUw1Q4Vs7KwCSGLMSdxE5xS4n+8ZAonLg9It MOBoXMbHD3y6KS89UGa0szIUhXDAfBVLQFuyqLL8uAzSWFZ7Lv3516SpmaN5CKFc uqrec+UruGeT0JdQOAYkgXGGPwHuVua/btp/DmEtSAQ3oteNhjUzxkzjc6jIbBKT sn75G5XUNHxNwInoGJYv9nAvvHpPn1r0OvEB9grBrdUEYiqDgUk50hXxcEDHto0/ 4JhXcs+TeqjqLVjKr+8C+jMFif/YiJT60X7KUNWpJIc7WGU/wwo6oEB3rDCd0Acl nfBXAe54Zgj8rHP4tQWtXkmUNshvAp6iWLktYi6Hw/x3NaWAuQRjZDBh+tkXPwVC BVpUPuSfm3HEkj2XHV8XCUOjY7Wc1+XXLteLocEhvoAqxtScnqZJa+ROA98QE9ZJ i0wmrdjMXEbDBYHNg1puhBpLl0i27qYcu7otOco/xfmSJ44Kcho= =XyMT -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191021160518.GA1430>