Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 23 Mar 2016 12:27:23 +0100
From:      Mathieu Arnold <mat@FreeBSD.org>
To:        Don Lewis <truckman@FreeBSD.org>
Cc:        ports@FreeBSD.org
Subject:   Re: gnome-post-install ordering
Message-ID:  <2F936CEC82E5BACE893F56D6@ogg.in.absolight.net>
In-Reply-To: <201603212043.u2LKhhuU061228@gw.catspoiler.org>
References:  <201603212043.u2LKhhuU061228@gw.catspoiler.org>

next in thread | previous in thread | raw e-mail | index | archive | help
--==========C028120EC9E624DE7999==========
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

+--On 21 mars 2016 13:43:43 -0700 Don Lewis <truckman@FreeBSD.org> wrote:
| On 21 Mar, Mathieu Arnold wrote:
|> +--On 21 mars 2016 11:18:26 -0700 Don Lewis <truckman@FreeBSD.org> wrote:
|> | gnome-post-install does several different things.  I haven't looked to
|> | see if all of them should be moved.  Unfortunately I'm not sure that an
|> | exp-run would pick up some of the more subtle breakage.
|> 
|> Then, we just extract the INSTALL_ICONS bits into a gnome-install-icons
|> target, and run it later, much later.  The gnome-post-install target
|> could benefit from being split up.  It was not so before because
|> USES=gnome is quite new, and adding stuff to the target ordering system
|> was a pain. Now, it could be splitted in gnome-gconf-schemas,
|> gnome-glib-schemas, gnome-installs-omf, and gnome-install-icons.  It was
|> on my roadmap when I rewrote the target ordering system to use numbers,
|> but I decided against changing too many things at once.
| 
| That sounds fine to me.  I didn't closely look at the rest of
| gnome-post-install since I was concentrating on the problem at hand.

I went looking around Mk/Uses for targets not using helpers, ended up with

https://reviews.freebsd.org/D5717

| I'd also like a target explicity for generating a dynamic plist that
| runs after post-install.  Doing it in post-install works most of the
| time unless you start using post-install option helpers to install
| additional files.

No, dynamic plists are evil you don't check what end up in the package, and
it's a mess.

The only exception is ruby gems and python modules because things change
too much between ruby/python versions and it can't be done another way.

|> | One of my concerns is that if we start using TARGET_ORDER_OVERRIDE all
|> | over the place, that will make maintaining the framework a lot more
|> | difficult.
|> 
|> There's a difference between all over the place and in a dozen ports :-)
|> (it only makes it about 0.05% of the time, if I get my math right)
| 
| Well, here are a bunch more ... these contain both INSTALLS_ICONS and
| "autoplist", which I'm assuming comes from USES_GNOME=autoplist

I think you mean USE_PYTHON=autoplist, but the python autoplist feature
only grabs stuff in the python module directory, so not icons.

-- 
Mathieu Arnold
--==========C028120EC9E624DE7999==========
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQJ8BAEBCgBmBQJW8n2cXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz
QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IJTUP/2lK37JT3Ux2AzaLLL/MjebZ
x9NyL48kG77XRn50S7g143h0dnXG7ooehxR64zGCHEnYd3G/RnssW0NByrsNI5Qk
4MQPDm9DEbzTWazkSKkwvsZgC8XDTNPqul164NhvfSWNRWE23N5GdgI+3hjDhnOA
w7bUcvQfP1G+kWzr9ixukcmJRE8EhhbvUNyGpsXUkfd2OYja9navmdM5iTrp32yI
1pj+4AJQOajiDsTEAlGHaiRd8QyNg+Vryv647E/WIwmkiIUul033KxU4uk3rbNFk
IbBBGJqRGGc/vfTjMXX9lggOT18YjjzaLOCY4PBm2tbAW8fLVFFX+vtK/K1Emt/q
j+qkz0sRXYvmWpCu4uKqo0zEUoCKCRZrlG+1d5bhYL9XZ/aHYmKBfEF9kwTs7mXe
wPrfoAYjyoYRl7veJudbjEotHYdDhaxoflEeYUcR40jaxBh+gjbYSUlBmkzx9CF0
n0NqChlseOLDh/AAUIFJ46W4TVmaEnZ7kHDFPZUc5zUo0vejO887Qwpq2qiY23y1
nXDTlp0Q25aA+U3OQnb2W4iUjyDFyE0POjzjDE4VRsUnEdyim6vgGgCMRV4b+ufq
ym/MEfAjteR9zjM6xW46XlaXM463HMCUzyy0DgXdBTUXZ+MxAUVpzi3RDHZd/uNG
xsA6SsQKjyVSK2lORIbt
=p4E6
-----END PGP SIGNATURE-----

--==========C028120EC9E624DE7999==========--




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2F936CEC82E5BACE893F56D6>