Date: Fri, 11 Oct 1996 16:43:48 -0600 (MDT) From: marcs@znep.com To: FreeBSD-gnats-submit@freebsd.org Subject: bin/1776: sysinstall doesn't compile in -stable Message-ID: <199610112243.QAA22348@alive.ampr.ab.ca> Resent-Message-ID: <199610112250.PAA02418@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 1776
>Category: bin
>Synopsis: sysinstall won't compile in -stable
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-bugs
>State: open
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Fri Oct 11 15:50:02 PDT 1996
>Last-Modified:
>Originator: Marc Slemko
>Organization:
>Release: FreeBSD 2.1-STABLE i386
>Environment:
A -stable source tree checked out from CVS using RELENG_2_1_0 as a tag.
The rest of the system is running the latest -stable.
>Description:
A function in options.c is defined with the wrong case, so it won't
compile. This looks like it is either a result of some changes made
to -current not making it back into -stable when they should, or some
changes made to -current making it back into -stable when they
shouldn't.
>How-To-Repeat:
cvs checkout -r RELENG_2_1_0 sysinstall
cd sysinstall
make
gcc will stop in options.c with the error:
options.c:114: `mediaSetFTPUserPass' undeclared here (not in a function)
options.c:114: initializer element for `Options.data' is not constant
*** Error code 1
>Fix:
The following patch is one fix to the problem, but the real fix may be
different depending on what the intent was.
Index: options.c
===================================================================
RCS file: /usr/cvs/src/release/sysinstall/options.c,v
retrieving revision 1.44
diff -c -r1.44 options.c
*** options.c 1996/10/02 01:30:37 1.44
--- options.c 1996/10/11 22:39:22
***************
*** 111,117 ****
{ "Yes to All", "Assume \"Yes\" answers to all non-critical dialogs",
OPT_IS_VAR, NULL, VAR_NO_CONFIRM, varCheck },
{ "FTP username", "Username and password to use instead of anonymous",
! OPT_IS_FUNC, mediaSetFTPUserPass, VAR_FTP_USER, varCheck },
{ "Editor", "Which text editor to use during installation",
OPT_IS_VAR, EDITOR_PROMPT, VAR_EDITOR, varCheck },
{ "Tape Blocksize", "Tape media block size in 512 byte blocks",
--- 111,117 ----
{ "Yes to All", "Assume \"Yes\" answers to all non-critical dialogs",
OPT_IS_VAR, NULL, VAR_NO_CONFIRM, varCheck },
{ "FTP username", "Username and password to use instead of anonymous",
! OPT_IS_FUNC, mediaSetFtpUserPass, VAR_FTP_USER, varCheck },
{ "Editor", "Which text editor to use during installation",
OPT_IS_VAR, EDITOR_PROMPT, VAR_EDITOR, varCheck },
{ "Tape Blocksize", "Tape media block size in 512 byte blocks",
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199610112243.QAA22348>