Date: Wed, 22 Feb 2023 09:31:04 +0800 From: Zhenlei Huang <zlei@FreeBSD.org> To: Mark Millard <marklmi@yahoo.com> Cc: FreeBSD-STABLE Mailing List <freebsd-stable@freebsd.org>, jlduran@gmail.com, Warner Losh <imp@FreeBSD.org>, Mateusz Piotrowski <0mp@FreeBSD.org>, "Tobias C. Berner" <tcberner@FreeBSD.org> Subject: Re: stable/13 snapshot's /etc/rc.d/machine_id has use of main's startmsg from /etc/rc.subr so it reports 2 "eval: startmsg: not found" Message-ID: <F1D469AF-375B-4C26-884F-A17868EFA6E2@FreeBSD.org> In-Reply-To: <5EA6BBBB-5947-4F78-9EB1-D9506FCA1860@FreeBSD.org> References: <212E6139-C634-4AE3-BFCF-F241D0C841CD@yahoo.com> <5EA6BBBB-5947-4F78-9EB1-D9506FCA1860@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] Sorry for missing the author tcberner@ of `libexec/rc/rc.d/machine_id`. > On Feb 22, 2023, at 9:25 AM, Zhenlei Huang <zlei@FreeBSD.org> wrote: > > Hi, > > `libexec/rc/rc.d/machine_id` (https://reviews.freebsd.org/D37722 <https://reviews.freebsd.org/D37722>) is MFC'ed into stable/13 but its precedence https://reviews.freebsd.org/D34514 <https://reviews.freebsd.org/D34514>; is not. > > So we should either MFC D34514, or change libexec/rc/rc.d/machine_id in stable/13 to use `check_startmsgs`. > > I'd personally prefer MFCing ;) > > Best regards, > Zhenlei > >> On Jan 22, 2023, at 11:32 AM, Mark Millard <marklmi@yahoo.com <mailto:marklmi@yahoo.com>> wrote: >> >> When I booted a new stable/13 snapshot install, the messaging >> included: >> >> . . . >> Updating motd:. >> eval: startmsg: not found >> eval: startmsg: not found >> Clearing /tmp (X related). >> . . . >> >> It looks like the "eval: startmsg: not found" lines >> are from: >> >> # grep -r "\<startmsg\>" /etc/ >> /etc/rc.d/machine_id: startmsg -n "Creating ${machine_id_file} " >> /etc/rc.d/machine_id: startmsg 'done.' >> >> (No more matches found.) >> >> The following was not found on stable/13: >> >> /etc/rc.subr:# startmsg >> /etc/rc.subr:startmsg() >> /etc/rc.subr: startmsg "Starting ${name}." >> >> >> === >> Mark Millard >> marklmi at yahoo.com <http://yahoo.com/>; >> >> > > > [-- Attachment #2 --] <html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Sorry for missing the author tcberner@ of `libexec/rc/rc.d/machine_id`.<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Feb 22, 2023, at 9:25 AM, Zhenlei Huang <<a href="mailto:zlei@FreeBSD.org" class="">zlei@FreeBSD.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html; charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Hi,<div class=""><br class=""></div><div class="">`libexec/rc/rc.d/machine_id` (<a href="https://reviews.freebsd.org/D37722" class="">https://reviews.freebsd.org/D37722</a>) is MFC'ed into stable/13 but its precedence <a href="https://reviews.freebsd.org/D34514" class="">https://reviews.freebsd.org/D34514</a> is not.</div><div class=""><br class=""></div><div class="">So we should either MFC D34514, or change <span style="caret-color: rgb(0, 0, 0);" class="">libexec/rc/rc.d/machine_id in stable/13 to use `</span><font class=""><span style="caret-color: rgb(0, 0, 0);" class="">check_startmsgs</span></font><span style="caret-color: rgb(0, 0, 0);" class="">`.</span></div><div class=""><br class=""></div><div class=""><font class=""><span style="caret-color: rgb(0, 0, 0);" class="">I'd personally prefer </span></font><span style="caret-color: rgb(0, 0, 0);" class="">MFCing ;)</span></div><div class=""><span style="caret-color: rgb(0, 0, 0);" class=""><br class=""></span></div><div class=""><div style="caret-color: rgb(0, 0, 0);" class="">Best regards,</div><div style="caret-color: rgb(0, 0, 0);" class="">Zhenlei</div></div><div class=""><div class=""><br class=""><blockquote type="cite" class=""><div class="">On Jan 22, 2023, at 11:32 AM, Mark Millard <<a href="mailto:marklmi@yahoo.com" class="">marklmi@yahoo.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">When I booted a new stable/13 snapshot install, the messaging<br class="">included:<br class=""><br class="">. . .<br class="">Updating motd:.<br class="">eval: startmsg: not found<br class="">eval: startmsg: not found<br class="">Clearing /tmp (X related).<br class="">. . .<br class=""><br class="">It looks like the "eval: startmsg: not found" lines<br class="">are from:<br class=""><br class=""># grep -r "\<startmsg\>" /etc/ <br class="">/etc/rc.d/machine_id: startmsg -n "Creating ${machine_id_file} "<br class="">/etc/rc.d/machine_id: startmsg 'done.'<br class=""><br class="">(No more matches found.)<br class=""><br class="">The following was not found on stable/13:<br class=""><br class="">/etc/rc.subr:# startmsg<br class="">/etc/rc.subr:startmsg()<br class="">/etc/rc.subr: startmsg "Starting ${name}."<br class=""><br class=""><br class="">===<br class="">Mark Millard<br class="">marklmi at <a href="http://yahoo.com/" class="">yahoo.com</a><br class=""><br class=""><br class=""></div></div></blockquote></div><div class=""><div class=""><br class=""></div> </div> <br class=""></div></div></div></blockquote></div><div class=""><div><br class=""></div> </div> <br class=""></body></html>help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F1D469AF-375B-4C26-884F-A17868EFA6E2>