Date: Wed, 22 Feb 2023 09:31:04 +0800 From: Zhenlei Huang <zlei@FreeBSD.org> To: Mark Millard <marklmi@yahoo.com> Cc: FreeBSD-STABLE Mailing List <freebsd-stable@freebsd.org>, jlduran@gmail.com, Warner Losh <imp@FreeBSD.org>, Mateusz Piotrowski <0mp@FreeBSD.org>, "Tobias C. Berner" <tcberner@FreeBSD.org> Subject: Re: stable/13 snapshot's /etc/rc.d/machine_id has use of main's startmsg from /etc/rc.subr so it reports 2 "eval: startmsg: not found" Message-ID: <F1D469AF-375B-4C26-884F-A17868EFA6E2@FreeBSD.org> In-Reply-To: <5EA6BBBB-5947-4F78-9EB1-D9506FCA1860@FreeBSD.org> References: <212E6139-C634-4AE3-BFCF-F241D0C841CD.ref@yahoo.com> <212E6139-C634-4AE3-BFCF-F241D0C841CD@yahoo.com> <5EA6BBBB-5947-4F78-9EB1-D9506FCA1860@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_BEE7CF78-A86C-407C-8464-4932DBF1AE8E Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Sorry for missing the author tcberner@ of `libexec/rc/rc.d/machine_id`. > On Feb 22, 2023, at 9:25 AM, Zhenlei Huang <zlei@FreeBSD.org> wrote: >=20 > Hi, >=20 > `libexec/rc/rc.d/machine_id` (https://reviews.freebsd.org/D37722 = <https://reviews.freebsd.org/D37722>) is MFC'ed into stable/13 but its = precedence https://reviews.freebsd.org/D34514 = <https://reviews.freebsd.org/D34514>; is not. >=20 > So we should either MFC D34514, or change libexec/rc/rc.d/machine_id = in stable/13 to use `check_startmsgs`. >=20 > I'd personally prefer MFCing ;) >=20 > Best regards, > Zhenlei >=20 >> On Jan 22, 2023, at 11:32 AM, Mark Millard <marklmi@yahoo.com = <mailto:marklmi@yahoo.com>> wrote: >>=20 >> When I booted a new stable/13 snapshot install, the messaging >> included: >>=20 >> . . . >> Updating motd:. >> eval: startmsg: not found >> eval: startmsg: not found >> Clearing /tmp (X related). >> . . . >>=20 >> It looks like the "eval: startmsg: not found" lines >> are from: >>=20 >> # grep -r "\<startmsg\>" /etc/=20 >> /etc/rc.d/machine_id: startmsg -n "Creating = ${machine_id_file} " >> /etc/rc.d/machine_id: startmsg 'done.' >>=20 >> (No more matches found.) >>=20 >> The following was not found on stable/13: >>=20 >> /etc/rc.subr:# startmsg >> /etc/rc.subr:startmsg() >> /etc/rc.subr: startmsg "Starting ${name}." >>=20 >>=20 >> =3D=3D=3D >> Mark Millard >> marklmi at yahoo.com <http://yahoo.com/>; >>=20 >>=20 >=20 >=20 >=20 --Apple-Mail=_BEE7CF78-A86C-407C-8464-4932DBF1AE8E Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii <html><head><meta http-equiv=3D"Content-Type" content=3D"text/html; = charset=3Dus-ascii"></head><body style=3D"word-wrap: break-word; = -webkit-nbsp-mode: space; line-break: after-white-space;" class=3D"">Sorry= for missing the author tcberner@ of `libexec/rc/rc.d/machine_id`.<br = class=3D""><div><br class=3D""><blockquote type=3D"cite" class=3D""><div = class=3D"">On Feb 22, 2023, at 9:25 AM, Zhenlei Huang <<a = href=3D"mailto:zlei@FreeBSD.org" class=3D"">zlei@FreeBSD.org</a>> = wrote:</div><br class=3D"Apple-interchange-newline"><div class=3D""><meta = http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dus-ascii" = class=3D""><div style=3D"word-wrap: break-word; -webkit-nbsp-mode: = space; line-break: after-white-space;" class=3D"">Hi,<div class=3D""><br = class=3D""></div><div class=3D"">`libexec/rc/rc.d/machine_id` (<a = href=3D"https://reviews.freebsd.org/D37722" = class=3D"">https://reviews.freebsd.org/D37722</a>) is MFC'ed into = stable/13 but its precedence <a = href=3D"https://reviews.freebsd.org/D34514" = class=3D"">https://reviews.freebsd.org/D34514</a> is not.</div><div = class=3D""><br class=3D""></div><div class=3D"">So we should either MFC = D34514, or change <span style=3D"caret-color: rgb(0, 0, 0);" = class=3D"">libexec/rc/rc.d/machine_id in stable/13 to use `</span><font = class=3D""><span style=3D"caret-color: rgb(0, 0, 0);" = class=3D"">check_startmsgs</span></font><span style=3D"caret-color: = rgb(0, 0, 0);" class=3D"">`.</span></div><div class=3D""><br = class=3D""></div><div class=3D""><font class=3D""><span = style=3D"caret-color: rgb(0, 0, 0);" class=3D"">I'd personally = prefer </span></font><span style=3D"caret-color: rgb(0, 0, 0);" = class=3D"">MFCing ;)</span></div><div class=3D""><span = style=3D"caret-color: rgb(0, 0, 0);" class=3D""><br = class=3D""></span></div><div class=3D""><div style=3D"caret-color: = rgb(0, 0, 0);" class=3D"">Best regards,</div><div style=3D"caret-color: = rgb(0, 0, 0);" class=3D"">Zhenlei</div></div><div class=3D""><div = class=3D""><br class=3D""><blockquote type=3D"cite" class=3D""><div = class=3D"">On Jan 22, 2023, at 11:32 AM, Mark Millard <<a = href=3D"mailto:marklmi@yahoo.com" class=3D"">marklmi@yahoo.com</a>> = wrote:</div><br class=3D"Apple-interchange-newline"><div class=3D""><div = class=3D"">When I booted a new stable/13 snapshot install, the = messaging<br class=3D"">included:<br class=3D""><br class=3D"">. . .<br = class=3D"">Updating motd:.<br class=3D"">eval: startmsg: not found<br = class=3D"">eval: startmsg: not found<br class=3D"">Clearing /tmp (X = related).<br class=3D"">. . .<br class=3D""><br class=3D"">It looks like = the "eval: startmsg: not found" lines<br class=3D"">are from:<br = class=3D""><br class=3D""># grep -r "\<startmsg\>" /etc/ <br = class=3D"">/etc/rc.d/machine_id: = startmsg -n = "Creating ${machine_id_file} "<br class=3D"">/etc/rc.d/machine_id: = startmsg = 'done.'<br class=3D""><br class=3D"">(No more matches found.)<br = class=3D""><br class=3D"">The following was not found on stable/13:<br = class=3D""><br class=3D"">/etc/rc.subr:# startmsg<br = class=3D"">/etc/rc.subr:startmsg()<br class=3D"">/etc/rc.subr: = &n= bsp; startmsg "Starting ${name}."<br = class=3D""><br class=3D""><br class=3D"">=3D=3D=3D<br class=3D"">Mark = Millard<br class=3D"">marklmi at <a href=3D"http://yahoo.com/" = class=3D"">yahoo.com</a><br class=3D""><br class=3D""><br = class=3D""></div></div></blockquote></div><div class=3D""><div = class=3D""><br class=3D""></div> </div> <br class=3D""></div></div></div></blockquote></div><div = class=3D""><div><br class=3D""></div> </div> <br class=3D""></body></html>= --Apple-Mail=_BEE7CF78-A86C-407C-8464-4932DBF1AE8E--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F1D469AF-375B-4C26-884F-A17868EFA6E2>