Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 7 Jul 2025 15:08:08 GMT
From:      Kristof Provost <kp@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 27626ff49ada - main - pfctl: Add parentheses for readability
Message-ID:  <202507071508.567F88kZ017037@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by kp:

URL: https://cgit.FreeBSD.org/src/commit/?id=27626ff49ada57f1978c893f21743e312dd40106

commit 27626ff49ada57f1978c893f21743e312dd40106
Author:     Kristof Provost <kp@FreeBSD.org>
AuthorDate: 2025-07-03 08:51:43 +0000
Commit:     Kristof Provost <kp@FreeBSD.org>
CommitDate: 2025-07-07 15:06:52 +0000

    pfctl: Add parentheses for readability
    
    Prompted by and OK deraadt
    
    Obtained from:  OpenBSD, kn <kn@openbsd.org>, ff93619fa5
    Sponsored by:   Rubicon Communications, LLC ("Netgate")
---
 sbin/pfctl/pfctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sbin/pfctl/pfctl.c b/sbin/pfctl/pfctl.c
index 8c20c8250ed1..738c89069383 100644
--- a/sbin/pfctl/pfctl.c
+++ b/sbin/pfctl/pfctl.c
@@ -3145,7 +3145,7 @@ main(int argc, char *argv[])
 	if ((opts & PF_OPT_NODNS) && (opts & PF_OPT_USEDNS))
 		errx(1, "-N and -r are mutually exclusive");
 
-	if (tblcmdopt == NULL ^ tableopt == NULL)
+	if ((tblcmdopt == NULL) ^ (tableopt == NULL))
 		usage();
 
 	if (tblcmdopt != NULL) {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202507071508.567F88kZ017037>