Date: Tue, 25 Dec 2018 07:53:49 +0300 From: Yuri Pankov <yuripv@yuripv.net> To: Mark Millard <marklmi@yahoo.com> Cc: FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: head -r3418363: top -opid process list order is rather odd (top -Saopid example shown) Message-ID: <c64fde66-ed43-a1a7-e2e3-f3bb6b78a297@yuripv.net> In-Reply-To: <DB7C0654-2017-4F8B-A286-8F67C34253CB@yahoo.com> References: <6C9BDD8A-7889-4819-86E3-CE13AC3323AC@yahoo.com> <d50b9e79-5790-f57b-3f92-e9a189fa7beb@yuripv.net> <DB7C0654-2017-4F8B-A286-8F67C34253CB@yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--4v1s2U7o7vur07W5BQnqHXGvA3wUwnm2p
Content-Type: multipart/mixed; boundary="SRfyl7p5hgj482QFXt6N3kP80snghYDig";
protected-headers="v1"
From: Yuri Pankov <yuripv@yuripv.net>
To: Mark Millard <marklmi@yahoo.com>
Cc: FreeBSD Current <freebsd-current@freebsd.org>
Message-ID: <c64fde66-ed43-a1a7-e2e3-f3bb6b78a297@yuripv.net>
Subject: Re: head -r3418363: top -opid process list order is rather odd (top
-Saopid example shown)
References: <6C9BDD8A-7889-4819-86E3-CE13AC3323AC@yahoo.com>
<d50b9e79-5790-f57b-3f92-e9a189fa7beb@yuripv.net>
<DB7C0654-2017-4F8B-A286-8F67C34253CB@yahoo.com>
In-Reply-To: <DB7C0654-2017-4F8B-A286-8F67C34253CB@yahoo.com>
--SRfyl7p5hgj482QFXt6N3kP80snghYDig
Content-Type: multipart/mixed;
boundary="------------2B8151DAFC2CDDA91116EAB3"
Content-Language: en-US
This is a multi-part message in MIME format.
--------------2B8151DAFC2CDDA91116EAB3
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Mark Millard wrote:
>=20
>=20
> On 2018-Dec-24, at 13:49, Yuri Pankov <yuripv at yuripv.net> wrote:
>=20
>> Mark Millard wrote:
>>> From my from=3Dsource head -r3418363 context, top with -opid does not=
>>> seem to sort in a coherent order, not time of process creation order
>>> (either direction) and not in just-PID numeric order (either
>>> direction). For example:
>>>
>>> PID USERNAME THR PRI NICE SIZE RES STATE C TIME WCPU=
COMMAND
>>> 0 root 24 -16 - 0 368K swapin 1 0:00 0.00%=
[kernel]
>>> 16 root 1 -16 - 0 16K - 3 0:00 0.00%=
[soaiod2]
>>> 752 root 1 20 0 18M 18M select 1 0:07 0.01%=
/usr/sbin/ntpd -p /var/db/ntp/ntpd.pid -c /etc/ntp.conf -g
>>> 800 root 1 20 0 11M 908K nanslp 1 0:01 0.00%=
/usr/sbin/cron -s
>>> 1 root 1 20 0 9900K 132K wait 3 0:00 0.00%=
[init]
>>> 17 root 1 -16 - 0 16K - 0 0:00 0.00%=
[soaiod3]
>>> 2 root 1 -16 - 0 16K crypto 0 0:00 0.00%=
[crypto]
>>> 18 root 1 -16 - 0 16K - 0 0:00 0.00%=
[soaiod4]
>>> 850 root 1 20 0 13M 2756K wait 3 0:00 0.00%=
login [pam] (login)
>>> 3 root 1 -16 - 0 16K crypto 0 0:00 0.00%=
[crypto returns 0]
>>> 19 root 1 -16 - 0 16K mmcsd 0 0:25 0.00%=
[mmcsd0: mmc/sd card]
>>> 643 root 1 20 0 11M 1124K select 2 0:01 0.00%=
/usr/sbin/syslogd -s
>>> 4 root 1 -16 - 0 16K crypto 0 0:00 0.00%=
[crypto returns 1]
>>> 20 root 1 -16 - 0 16K mmcsd 0 0:00 0.00%=
[mmcsd0boot0: mmc/sd]
>>> 5 root 1 -16 - 0 16K crypto 0 0:00 0.00%=
[crypto returns 2]
>>> 21 root 1 -16 - 0 16K mmcsd 0 0:00 0.00%=
[mmcsd0boot1: mmc/sd]
>>> 6 root 1 -16 - 0 16K crypto 0 0:00 0.00%=
[crypto returns 3]
>>> 22 root 3 -16 - 0 48K psleep 3 0:12 0.00%=
[pagedaemon]
>>> 5270 root 1 20 0 14M 3780K CPU2 2 0:00 0.14%=
top -Saopid
>>> 662 root 1 20 0 11M 680K select 0 0:00 0.00%=
/usr/sbin/rpcbind
>>> 7 root 2 -16 - 0 32K - 0 0:00 0.00%=
[cam]
>>> 23 root 1 -16 - 0 16K psleep 2 0:00 0.00%=
[vmdaemon]
>>> 5255 root 1 20 0 12M 3092K wait 0 0:00 0.00%=
-sh (sh)
>>> 8 root 1 -16 - 0 16K waitin 0 0:00 0.00%=
[sctp_iterator]
>>> 24 root 3 -16 - 0 48K qsleep 3 0:12 0.01%=
[bufdaemon]
>>> 712 root 1 52 0 12M 616K select 0 0:00 0.00%=
/usr/sbin/mountd -r
>>> 9 root 1 -16 - 0 16K - 1 0:04 0.00%=
[rand_harvestq]
>>> 25 root 1 20 - 0 16K vlruwt 0 0:04 0.00%=
[vnlru]
>>> 10 root 1 -16 - 0 16K audit_ 0 0:00 0.00%=
[audit]
>>> 26 root 1 16 - 0 16K syncer 0 1:45 0.00%=
[syncer]
>>> 714 root 1 52 0 12M 728K select 3 0:00 0.00%=
nfsd: master (nfsd)
>>> 11 root 4 155 ki31 0 64K CPU0 0 144.6H 397.09%=
[idle]
>>> 235 root 1 20 0 11M 564K select 3 0:00 0.00%=
dhclient: system.syslog (dhclient)
>>> 715 root 32 52 0 11M 1120K rpcsvc 3 0:00 0.00%=
nfsd: server (nfsd)
>>> 12 root 18 -52 - 0 288K WAIT 2 2:29 1.43%=
[intr]
>>> 412 root 1 20 0 10M 72K select 2 0:00 0.00%=
/sbin/devd
>>> 796 root 1 52 0 20M 672K select 0 0:00 0.00%=
/usr/sbin/sshd
>>> 13 root 3 -8 - 0 48K - 1 0:11 0.00%=
[geom]
>>> 14 root 20 -68 - 0 320K - 0 0:02 0.00%=
[usb]
>>> 238 root 1 52 0 12M 416K select 1 0:00 0.00%=
dhclient: awg0 [priv] (dhclient)
>>> 15 root 1 -16 - 0 16K - 0 0:00 0.00%=
[soaiod1]
>>> 239 _dhcp 1 20 0 12M 484K select 1 0:00 0.00%=
dhclient: awg0 (dhclient)
>>>
>>> (Basically the Pine64+ 2GB [aarch64] above was idle after boot other =
than
>>> some runs of top.)
>>>
>>> I see this oddity across architectures, for example amd64, powerpc64,=
>>> aarch64, armv7.
>>
>> No wonder, it doesn't seem to have worked ever (?) as the compare_pid =
is
>> simply not defined in compares list. Try attached patch.
>> <top.diff>
>=20
> I'm a long term top user and it used to work. For example, when I was r=
unning
> head -r340287 it worked as I remember. (I recreated such a vintage rece=
ntly
> for a test of something else. The -opid ordering was coherent as I reme=
mber,
> unlike the above.)
>=20
> It historically seemed to track the time order of process creation, eve=
n around the PID
> number wrapping around. (So not a strict PID sort, at least for the PID=
shown.) This
> was handy for monitoring buildworld buidkernel and port builds (all par=
allel).
>=20
> I'll probably try the patch when I have a chance, even if it does stric=
t PID number
> order. Thanks.
OK, so top never did sort for '-opid' by itself, and rather relied on
the process list to be sorted by birth time internally (as returned by
kvm_getprocs()) and it doesn't seem to be really sorting by PID, more so
when PID numbers wrap. Quick bisect shows that this behavior was
changed by r340742 ("proc: implement pid hash locks and an iterator"),
so I guess we now just need to implement real sorting by PID.
I have attached another patch version adding pid comparison function
done like the other ones.
--------------2B8151DAFC2CDDA91116EAB3
Content-Type: text/plain; charset=UTF-8;
name="top.diff"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
filename="top.diff"
ZGlmZiAtLWdpdCBhL3Vzci5iaW4vdG9wL21hY2hpbmUuYyBiL3Vzci5iaW4vdG9wL21hY2hp
bmUuYwppbmRleCAzNzRjOWRhMGVkZjQuLjhjMGRiMzY1ZjhhNSAxMDA2NDQKLS0tIGEvdXNy
LmJpbi90b3AvbWFjaGluZS5jCisrKyBiL3Vzci5iaW4vdG9wL21hY2hpbmUuYwpAQCAtMTI3
Niw2ICsxMjc2LDEyIEBAIHN0YXRpYyBpbnQgc29ydGVkX3N0YXRlW10gPSB7CiAJCXJldHVy
biAoZGlmZiA+IDAgPyAxIDogLTEpOyBcCiB9IHdoaWxlICgwKQogCisjZGVmaW5lIE9SREVS
S0VZX1BJRChhLCBiKSBkbyB7IFwKKwlpbnQgZGlmZiA9IChpbnQpYi0+a2lfcGlkIC0gKGlu
dClhLT5raV9waWQ7IFwKKwlpZiAoZGlmZiAhPSAwKSBcCisJCXJldHVybiAoZGlmZiA+IDAg
PyAxIDogLTEpOyBcCit9IHdoaWxlICgwKQorCiAvKiBjb21wYXJlX2NwdSAtIHRoZSBjb21w
YXJpc29uIGZ1bmN0aW9uIGZvciBzb3J0aW5nIGJ5IGNwdSBwZXJjZW50YWdlICovCiAKIHN0
YXRpYyBpbnQKQEAgLTE0MjAsNiArMTQyNiwyNCBAQCBjb21wYXJlX3N3YXAoY29uc3Qgdm9p
ZCAqYXJnMSwgY29uc3Qgdm9pZCAqYXJnMikKIAlyZXR1cm4gKDApOwogfQogCisvKiBjb21w
YXJlX3Byb2Nlc3NpZCAtIHRoZSBjb21wYXJpc29uIGZ1bmN0aW9uIGZvciBzb3J0aW5nIGJ5
IHBpZCAqLworc3RhdGljIGludAorY29tcGFyZV9wcm9jZXNzaWQoY29uc3Qgdm9pZCAqYXJn
MSwgY29uc3Qgdm9pZCAqYXJnMikKK3sKKwljb25zdCBzdHJ1Y3Qga2luZm9fcHJvYyAqcDEg
PSAqKGNvbnN0IHN0cnVjdCBraW5mb19wcm9jICogY29uc3QgKilhcmcxOworCWNvbnN0IHN0
cnVjdCBraW5mb19wcm9jICpwMiA9ICooY29uc3Qgc3RydWN0IGtpbmZvX3Byb2MgKiBjb25z
dCAqKWFyZzI7CisKKwlPUkRFUktFWV9QSUQocDEsIHAyKTsKKwlPUkRFUktFWV9QQ1RDUFUo
cDEsIHAyKTsKKwlPUkRFUktFWV9DUFRJQ0tTKHAxLCBwMik7CisJT1JERVJLRVlfU1RBVEUo
cDEsIHAyKTsKKwlPUkRFUktFWV9QUklPKHAxLCBwMik7CisJT1JERVJLRVlfUlNTSVpFKHAx
LCBwMik7CisJT1JERVJLRVlfTUVNKHAxLCBwMik7CisKKwlyZXR1cm4gKDApOworfQorCiAv
KiBhc3NvcnRlZCBjb21wYXJpc29uIGZ1bmN0aW9ucyBmb3Igc29ydGluZyBieSBpL28gKi8K
IAogc3RhdGljIGludApAQCAtMTUxMSw3ICsxNTM1LDcgQEAgaW50ICgqY29tcGFyZXNbXSko
Y29uc3Qgdm9pZCAqYXJnMSwgY29uc3Qgdm9pZCAqYXJnMikgPSB7CiAJY29tcGFyZV9pdmNz
dywKIAljb21wYXJlX2ppZCwKIAljb21wYXJlX3N3YXAsCi0JTlVMTAorCWNvbXBhcmVfcHJv
Y2Vzc2lkCiB9OwogCiAK
--------------2B8151DAFC2CDDA91116EAB3--
--SRfyl7p5hgj482QFXt6N3kP80snghYDig--
--4v1s2U7o7vur07W5BQnqHXGvA3wUwnm2p
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCAAdFiEE+Gq3PsPeLT4tL/9wk4vgf7Eq4WwFAlwht90ACgkQk4vgf7Eq
4Wx0UggAmpx319hfalXo1XK1W1bgcIyR8JYIxye6pIJNBZ3Pr4teQ6bJV8GlzVRG
MBX84PHE4nHNjG4ohuv9fZTPv928GCOOxL2Y5gMd5nURz50yzZLqE+JeXaurp4Jh
n9F4k0JPVvgT2jPRU+XoneKq0Jvz4zGK54JUPXjGCLjgOsg0lmVv3kgcKXB1rC2u
pJdUGMPtqUm9GHCdM9K7X3rMf0hrb7JwEBWFZndFRR+XTiQzUSQDBCJ8e7KM+r5d
/uIBCYSQzCujKiiXPea2H+XxqQnxgf/m6+Y/75fXIkVPVOH1OZA4wYr5ht9uSD20
slscmvW/kfcgoTV0IXAX19f+cn2KwA==
=Ggk8
-----END PGP SIGNATURE-----
--4v1s2U7o7vur07W5BQnqHXGvA3wUwnm2p--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c64fde66-ed43-a1a7-e2e3-f3bb6b78a297>