Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 29 Oct 2013 13:21:48 -0400 (EDT)
From:      Benjamin Kaduk <kaduk@MIT.EDU>
To:        Eitan Adler <eadler@freebsd.org>
Cc:        svn-doc-head@freebsd.org, svn-doc-all@freebsd.org, doc-committers@freebsd.org
Subject:   Re: svn commit: r43055 - head/en_US.ISO8859-1/books/porters-handbook
Message-ID:  <alpine.GSO.1.10.1310291319320.4934@multics.mit.edu>
In-Reply-To: <201310281917.r9SJH8Gd097201@svn.freebsd.org>
References:  <201310281917.r9SJH8Gd097201@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 28 Oct 2013, Eitan Adler wrote:

> Author: eadler
> Date: Mon Oct 28 19:17:08 2013
> New Revision: 43055
> URL: http://svnweb.freebsd.org/changeset/doc/43055
>
> Log:
>  Add STAGEDIR where needed (in some cases)
>
> Modified:
>  head/en_US.ISO8859-1/books/porters-handbook/book.xml
>
> Modified: head/en_US.ISO8859-1/books/porters-handbook/book.xml
> ==============================================================================
> --- head/en_US.ISO8859-1/books/porters-handbook/book.xml	Mon Oct 28 19:13:05 2013	(r43054)
> +++ head/en_US.ISO8859-1/books/porters-handbook/book.xml	Mon Oct 28 19:17:08 2013	(r43055)
> @@ -5036,7 +5036,7 @@ PORTVERSION=	1.0</programlisting>
> 	  example:</para>
>
> 	<programlisting>post-install:
> -	${STRIP_CMD} ${PREFIX}/bin/xdl</programlisting>
> +	  ${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/xdl</programlisting>
>
> 	<para>Use the &man.file.1; command on the installed executable
> 	  to check whether the binary is stripped or not.  If it does
> @@ -5068,8 +5068,8 @@ PORTVERSION=	1.0</programlisting>
> 	  target.</para>
>
> 	<programlisting>post-install:
> -	${MKDIR} ${EXAMPLESDIR}
> -	(cd ${WRKSRC}/examples &amp;&amp; ${COPYTREE_SHARE} . ${EXAMPLESDIR})</programlisting>
> +	  ${MKDIR} ${STAGEDIR}${EXAMPLESDIR}
> +	  (cd ${WRKSRC}/examples &amp;&amp; ${COPYTREE_SHARE} . ${STAGEDIR}${EXAMPLESDIR})</programlisting>
>
> 	<para>This example will install the contents of
> 	  <filename>examples</filename> directory in the vendor
> @@ -5077,8 +5077,8 @@ PORTVERSION=	1.0</programlisting>
> 	  port.</para>
>
> 	<programlisting>post-install:
> -	${MKDIR} ${DATADIR}/summer
> -	(cd ${WRKSRC}/temperatures &amp;&amp; ${COPYTREE_SHARE} "June July August" ${DATADIR}/summer)</programlisting>
> +	  ${MKDIR} ${STAGEDIR}${DATADIR}/summer
> +	  (cd ${WRKSRC}/temperatures &amp;&amp; ${COPYTREE_SHARE} "June July August" ${STAGEDIR}${DATADIR}/summer)</programlisting>
>
> 	<para>And this example will install the data of summer months
> 	  to the <filename>summer</filename> subdirectory of a
> @@ -5091,9 +5091,9 @@ PORTVERSION=	1.0</programlisting>
> 	  one can use the following command.</para>
>
> 	<programlisting>post-install:
> -	${MKDIR} ${EXAMPLESDIR}
> +	  ${MKDIR} ${STAGEDIR}${EXAMPLESDIR}
> 	(cd ${WRKSRC}/examples &amp;&amp; \
> -		${COPYTREE_SHARE} . ${EXAMPLESDIR} "! -name Makefile")</programlisting>
> +	${COPYTREE_SHARE} . ${STAGEDIR}${EXAMPLESDIR} "! -name Makefile")</programlisting>
>
> 	<para>Note that these macros does not add the installed files
> 	  to <filename>pkg-plist</filename>.  You still need to list
> @@ -10008,7 +10008,7 @@ lib/X11/oneko/sounds/cat.au
>
>       <programlisting>post-install:
> 	@if [ ! -f ${PREFIX}/etc/orbit.conf ]; then \
> -		${CP} -p ${PREFIX}/etc/orbit.conf.sample ${PREFIX}/etc/orbit.conf ; \
> +	${CP} -p ${PREFIX}/etc/orbit.conf.sample ${STAGEDIR}${PREFIX}/etc/orbit.conf ; \
> 	fi</programlisting>
>
>       <para>For each configuration file, create the following three

The loss of internal indentation within the programlisting for the normal 
indentation with nested control flow is unfortunate.  That is, the body of 
if statements is normally indented another level, as are continuation 
lines in a subshell.

-Ben



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.GSO.1.10.1310291319320.4934>