Date: Wed, 17 Aug 2016 17:03:44 +0200 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: Nathan Whitehorn <nwhitehorn@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r304142 - head/usr.sbin/bsdinstall/partedit Message-ID: <86wpjf4eun.fsf@desk.des.no> In-Reply-To: <581c856c-826b-529e-c9c6-a397fb679708@freebsd.org> (Nathan Whitehorn's message of "Wed, 17 Aug 2016 07:36:00 -0700") References: <201608150930.u7F9UL1V069576@repo.freebsd.org> <e3454e8e-5d98-5bec-21de-8ea0db2b9b08@freebsd.org> <861t1n6749.fsf@desk.des.no> <581c856c-826b-529e-c9c6-a397fb679708@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Nathan Whitehorn <nwhitehorn@freebsd.org> writes: > Dag-Erling Sm=C3=B8rgrav <des@des.no> writes: > > [...] And you keep refusing to address the fact that most drivers > > don't report a stripe size, except by repeating your claim that they > > do, with no evidence to back it up. Feel free to 'grep -r > > stripesize /usr/src/sys/dev'. Go on, I'll wait. > And yet, if you look at the GEOM XML, it is reported and there. And, > look, it's even right for the AF 512e disks in my machine! Yes, that is one of the few cases where we get it right, as previously mentioned. But it only works because it's known to us (listed in the quirk table) and directly attached. If you replace that drive with a brand new one a year from now, you have no guarantee that the new drive will be recognized as an AF drive. > I've literally never seen a case where we don't already do the right > thing here. The I can only conclude that you have very little real-world experience. I have mentioned several examples to you, and even told you how to confirm, by inspecting the source code, that most drivers do *not* set the stripe size. > It's correct, as far as I can tell, 100% of the time on all possible > variants of AF disks. You keep repeating this, as if it somehow proves me wrong. It doesn't. > One could argue that calling this the "stripesize" is a hack, and I > would agree, One could, but one would be wrong. > As for grepping, the CAM disk drivers are all in sys/cam, not sys/dev, > as I'm sure you know, and you will find all the code that handles this > there. Only for directly attached drives, and most drives do not report the correct physical sector size, which is why we have quirk tables. > We should just fix the driver for whatever weird disk you have in your > machine (what is it, by the way?). Oh please. Now you're just being an <expletive>. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86wpjf4eun.fsf>