Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 12 Apr 2005 20:38:20 +0200
From:      "Simon L. Nielsen" <simon@nitro.dk>
To:        Mark Linimon <linimon@lonesome.com>
Cc:        freebsd-doc@FreeBSD.org
Subject:   Re: CFD: additions to the PR submission article
Message-ID:  <20050412183820.GD837@zaphod.nitro.dk>
In-Reply-To: <Pine.LNX.4.44.0504110437400.2500-100000@pancho>
References:  <20050411092513.GB71160@eddie.nitro.dk> <Pine.LNX.4.44.0504110437400.2500-100000@pancho>

index | next in thread | previous in thread | raw e-mail

[-- Attachment #1 --]
On 2005.04.11 04:40:42 -0500, Mark Linimon wrote:
> On Mon, 11 Apr 2005, Simon L. Nielsen wrote:
> 
> > > +      </listitem>
> > > +
> > 
> > No need for an empty line here.
> 
> Hmm, then the style is wrong elsewhere in the article.

That sounds likely.  It's not very important, I just notice things
like that when I read a patch :-).

> > > +    <para>Then you should ascertain whether or not the problem is
> > > +      timely.  There are few things
> > 
> > This line could be made longer.
> 
> Weak attempt at a diff reduction on the next line.  OTOH since I
> moved the block that that line was in to make the emphasis clearer,
> it may not make any difference.

When the text is moved I don't think it it helps much to preserve old
lines, but I don't know if it makes a difference for translators.

> > > +      <ulink url="http://www.freebsd.org/security/">list of supported
> > 
> > s/freebsd.org/FreeBSD.org/
> 
> Also wrong elsewhere IIRC.
> 
> I can make these suggested changes when I commit, and then go back and
> fix the other ones in a separate checkin to make them consistent.

That would be great!

-- 
Simon L. Nielsen

[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (FreeBSD)

iD8DBQFCXBWbh9pcDSc1mlERAqrIAJ4igj/E3zXSyLY+1daHPH37L+W76gCcClbH
YB2vfSNY54eJJaWPW/K5I5o=
=AVYZ
-----END PGP SIGNATURE-----
home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050412183820.GD837>