Date: Mon, 8 Feb 1999 11:28:31 -0800 (PST) From: John Polstra <jdp@polstra.com> To: guido@FreeBSD.ORG Cc: committers@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/ibcs2 ibcs2_ipc.c ibcs2_ipc.h Message-ID: <199902081928.LAA43869@vashon.polstra.com> In-Reply-To: <199902071935.LAA64323@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In article <199902071935.LAA64323@freefall.freebsd.org>,
Guido van Rooij <guido@FreeBSD.ORG> wrote:
> guido 1999/02/07 11:35:40 PST
>
> Modified files:
> sys/i386/ibcs2 ibcs2_ipc.c ibcs2_ipc.h
> Log:
> 1) Fix our view of how ibcs2_semid_ds looks. There is no padding int there
> (SVR4 does have it so that;s probably the cause of this bug)
> 2) Add a wrapper function for translation between ibcs2_ipc_perm and
> ipc_perm as I think we screwed up when defining the ipc_perm struct and
> mixed up 'normal' and creator [ug]id's
> 3) Fix IBCS2_IPC_STAT semctl. The FreeBSD version needs a union semun
> whereas the IBCS2 version gives a struct ibcs2_semid_ds.
>
> Apparently this is all fixed in the SVR4 compatibility code.
> PR: 7729
>
> Revision Changes Path
> 1.14 +45 -11 src/sys/i386/ibcs2/ibcs2_ipc.c
> 1.4 +1 -2 src/sys/i386/ibcs2/ibcs2_ipc.h
This breaks make buildworld:
cc -O -pipe -Wformat -DCOMPAT_IBCS2 -DKERNEL -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -DKLD_MODULE -nostdinc -I- -I/usr/obj/usr/src/sys/modules/ibcs2 -I/usr/obj/usr/src/sys/modules/ibcs2/@ -I/usr/obj/usr/src/tmp/usr/include -c /usr/src/sys/modules/ibcs2/../../i386/ibcs2/ibcs2_ipc.c
/usr/src/sys/modules/ibcs2/../../i386/ibcs2/ibcs2_ipc.c:58: warning: `struct ibcs2_ipc_perm' declared inside parameter list
/usr/src/sys/modules/ibcs2/../../i386/ibcs2/ibcs2_ipc.c:58: warning: its scope is only this definition or declaration,
/usr/src/sys/modules/ibcs2/../../i386/ibcs2/ibcs2_ipc.c:58: warning: which is probably not what you want.
/usr/src/sys/modules/ibcs2/../../i386/ibcs2/ibcs2_ipc.c:59: warning: `struct ibcs2_ipc_perm' declared inside parameter list
/usr/src/sys/modules/ibcs2/../../i386/ibcs2/ibcs2_ipc.c: In function `cvt_msqid2imsqid':
/usr/src/sys/modules/ibcs2/../../i386/ibcs2/ibcs2_ipc.c:71: warning: passing arg 2 of `cvt_perm2iperm' from incompatible pointer type
/usr/src/sys/modules/ibcs2/../../i386/ibcs2/ibcs2_ipc.c: In function `cvt_imsqid2msqid':
/usr/src/sys/modules/ibcs2/../../i386/ibcs2/ibcs2_ipc.c:90: warning: passing arg 1 of `cvt_iperm2perm' from incompatible pointer type
/usr/src/sys/modules/ibcs2/../../i386/ibcs2/ibcs2_ipc.c: In function `cvt_iperm2perm':
/usr/src/sys/modules/ibcs2/../../i386/ibcs2/ibcs2_ipc.c:185: argument `ipp' doesn't match prototype
/usr/src/sys/modules/ibcs2/../../i386/ibcs2/ibcs2_ipc.c:59: prototype declaration
/usr/src/sys/modules/ibcs2/../../i386/ibcs2/ibcs2_ipc.c:186: dereferencing pointer to incomplete type
/usr/src/sys/modules/ibcs2/../../i386/ibcs2/ibcs2_ipc.c:187: dereferencing pointer to incomplete type
/usr/src/sys/modules/ibcs2/../../i386/ibcs2/ibcs2_ipc.c:188: dereferencing pointer to incomplete type
/usr/src/sys/modules/ibcs2/../../i386/ibcs2/ibcs2_ipc.c:189: dereferencing pointer to incomplete type
/usr/src/sys/modules/ibcs2/../../i386/ibcs2/ibcs2_ipc.c:190: dereferencing pointer to incomplete type
/usr/src/sys/modules/ibcs2/../../i386/ibcs2/ibcs2_ipc.c:191: dereferencing pointer to incomplete type
/usr/src/sys/modules/ibcs2/../../i386/ibcs2/ibcs2_ipc.c:192: dereferencing pointer to incomplete type
/usr/src/sys/modules/ibcs2/../../i386/ibcs2/ibcs2_ipc.c: In function `cvt_perm2iperm':
/usr/src/sys/modules/ibcs2/../../i386/ibcs2/ibcs2_ipc.c:199: argument `ipp' doesn't match prototype
/usr/src/sys/modules/ibcs2/../../i386/ibcs2/ibcs2_ipc.c:58: prototype declaration
/usr/src/sys/modules/ibcs2/../../i386/ibcs2/ibcs2_ipc.c:200: dereferencing pointer to incomplete type
/usr/src/sys/modules/ibcs2/../../i386/ibcs2/ibcs2_ipc.c:201: dereferencing pointer to incomplete type
/usr/src/sys/modules/ibcs2/../../i386/ibcs2/ibcs2_ipc.c:202: dereferencing pointer to incomplete type
/usr/src/sys/modules/ibcs2/../../i386/ibcs2/ibcs2_ipc.c:203: dereferencing pointer to incomplete type
/usr/src/sys/modules/ibcs2/../../i386/ibcs2/ibcs2_ipc.c:204: dereferencing pointer to incomplete type
/usr/src/sys/modules/ibcs2/../../i386/ibcs2/ibcs2_ipc.c:205: dereferencing pointer to incomplete type
/usr/src/sys/modules/ibcs2/../../i386/ibcs2/ibcs2_ipc.c:206: dereferencing pointer to incomplete type
/usr/src/sys/modules/ibcs2/../../i386/ibcs2/ibcs2_ipc.c: In function `cvt_semid2isemid':
/usr/src/sys/modules/ibcs2/../../i386/ibcs2/ibcs2_ipc.c:214: warning: passing arg 2 of `cvt_perm2iperm' from incompatible pointer type
/usr/src/sys/modules/ibcs2/../../i386/ibcs2/ibcs2_ipc.c: In function `cvt_isemid2semid':
/usr/src/sys/modules/ibcs2/../../i386/ibcs2/ibcs2_ipc.c:227: warning: passing arg 1 of `cvt_iperm2perm' from incompatible pointer type
/usr/src/sys/modules/ibcs2/../../i386/ibcs2/ibcs2_ipc.c: In function `cvt_shmid2ishmid':
/usr/src/sys/modules/ibcs2/../../i386/ibcs2/ibcs2_ipc.c:318: warning: passing arg 2 of `cvt_perm2iperm' from incompatible pointer type
/usr/src/sys/modules/ibcs2/../../i386/ibcs2/ibcs2_ipc.c: In function `cvt_ishmid2shmid':
/usr/src/sys/modules/ibcs2/../../i386/ibcs2/ibcs2_ipc.c:335: warning: passing arg 1 of `cvt_iperm2perm' from incompatible pointer type
*** Error code 1
John
--
John Polstra jdp@polstra.com
John D. Polstra & Co., Inc. Seattle, Washington USA
"Nobody ever went broke underestimating the taste of the American public."
-- H. L. Mencken
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199902081928.LAA43869>