Date: Mon, 9 Sep 1996 22:06:10 -0500 (CDT) From: Steve Price <steve@bonsai.hiwaay.net> To: roberte@ghost.mep.ruhr-uni-bochum.de Cc: henrich@crh.cl.msu.edu, hackers@freebsd.org Subject: Re: bin/1590: AT time parsing broken Message-ID: <199609100306.WAA12875@bonsai.hiwaay.net>
next in thread | raw e-mail | index | archive | help
Robert Eckardt wrote: # # The following reply was made to PR bin/1590; it has been noted by GNATS. # # From: Robert Eckardt <roberte@ghost.mep.ruhr-uni-bochum.de> # To: henrich@msu.edu # Cc: FreeBSD-gnats-submit@freebsd.org # Subject: Re: bin/1590: AT time parsing broken # Date: Tue, 10 Sep 1996 02:48:22 +0200 (MET DST) # # > FreeBSD 2.2-960801-SNAP # [..] # > 1:22pm crh> at 1pm tommorow # > at: Trying to travel back in time # # Have you tried `at 1pm tomorrow' instead ? # ~~~ # I tried it on 2.1.5-R: # # 2:45 ghost: /home/re 1% at 2am tommorow # at: Trying to travel back in time # 2:45 ghost: /home/re 1% at 2am tomorrow # _ # # # Robert You saw that too. :) at(1) seems to ignore the command line after the time arguments (at least sometimes). IMHO, an invalid keyword should be treated as such. In light of my opinion, I suggest the following patch. Oh yeah, I threw in a gratiutous spelling correction to boot. :) Steve Index: parsetime.c =================================================================== RCS file: /u/FreeBSD/cvs/src/usr.bin/at/parsetime.c,v retrieving revision 1.7 diff -u -r1.7 parsetime.c --- parsetime.c 1996/07/19 00:44:55 1.7 +++ parsetime.c 1996/09/10 02:55:31 @@ -149,7 +149,8 @@ } /* not special - must be some random id */ - return ID; + panic("garbled time"); + return ID; /* NOTREACHED */ } /* parse_token */ @@ -357,7 +358,7 @@ else if (tlen == 4) { minute = hour%100; if (minute > 59) - panic("garbeld time"); + panic("garbled time"); hour = hour/100; }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199609100306.WAA12875>