Date: Fri, 12 Mar 2010 07:47:56 +0000 From: "Robert N. M. Watson" <rwatson@freebsd.org> To: Qing Li <qingli@freebsd.org> Cc: Juli Mallett <jmallett@freebsd.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r205024 - head/sys/net Message-ID: <DED0E826-F9A4-4932-8A84-CD4B5FED8C62@freebsd.org> In-Reply-To: <9ace436c1003111618t28dba8d8x19aeff2acff0c489@mail.gmail.com> References: <201003111756.o2BHukJu042449@svn.freebsd.org> <alpine.BSF.2.00.1003112128020.97017@fledge.watson.org> <9ace436c1003111530s3bd0de9cq451671909fb6aa64@mail.gmail.com> <eaa228be1003111535s12febe62x91124b0a015fd0ff@mail.gmail.com> <9ace436c1003111539t2af8439cn315c695d4b90e28d@mail.gmail.com> <eaa228be1003111607s4e78fe73k26a67161642d510d@mail.gmail.com> <9ace436c1003111618t28dba8d8x19aeff2acff0c489@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mar 12, 2010, at 12:18 AM, Qing Li wrote: > You definitely have a very good point here. I was a bit surprised > during debugging that the link state is not consistently initialized > and by far not enforced across all of the drivers. Admittedly I checked > the most commonly deployed devices and they are in good state. > > I certainly appreciate your patience on this one and will try to get > it resolved quickly. One of the reasons drivers don't do this consistently his that historically, hardware has not consistently supported link state detection. This now does seem to be a standard feature, but I think it would be useful to continue to support some notion of a driver not supporting it, hence my thoughts on a link state capability: only test link state if the driver can implement it. Otherwise, you end up with a link state undefined state, which likely comes to much the same thing, and is presumably what in practice you get today on drivers that don't set it. Robert
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?DED0E826-F9A4-4932-8A84-CD4B5FED8C62>