Date: Wed, 11 Jan 2017 21:01:50 +0000 (UTC) From: Dimitry Andric <dim@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Subject: svn commit: r311939 - in stable: 10/sys/geom/vinum 11/sys/geom/vinum 9/sys/geom/vinum Message-ID: <201701112101.v0BL1o8K069902@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: dim Date: Wed Jan 11 21:01:49 2017 New Revision: 311939 URL: https://svnweb.freebsd.org/changeset/base/311939 Log: MFC r311688: Fix logic error in gvinum's gv_set_sd_state() With clang 4.0.0, I'm getting the following warnings: sys/geom/vinum/geom_vinum_state.c:186:7: error: logical not is only applied to the left hand side of this bitwise operator [-Werror,-Wlogical-not-parentheses] if (!flags & GV_SETSTATE_FORCE) ^ ~ The logical not operator should obiously be called after masking. Reviewed by: mav, pfg Differential Revision: https://reviews.freebsd.org/D9093 Modified: stable/10/sys/geom/vinum/geom_vinum_state.c Directory Properties: stable/10/ (props changed) Changes in other areas also in this revision: Modified: stable/11/sys/geom/vinum/geom_vinum_state.c stable/9/sys/geom/vinum/geom_vinum_state.c Directory Properties: stable/11/ (props changed) stable/9/ (props changed) stable/9/sys/ (props changed) Modified: stable/10/sys/geom/vinum/geom_vinum_state.c ============================================================================== --- stable/10/sys/geom/vinum/geom_vinum_state.c Wed Jan 11 20:55:01 2017 (r311938) +++ stable/10/sys/geom/vinum/geom_vinum_state.c Wed Jan 11 21:01:49 2017 (r311939) @@ -183,7 +183,7 @@ gv_set_sd_state(struct gv_sd *s, int new * Only do this if we're forced, since it usually is done * internally, and then we do use the force flag. */ - if (!flags & GV_SETSTATE_FORCE) + if (!(flags & GV_SETSTATE_FORCE)) return (GV_ERR_SETSTATE); break;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201701112101.v0BL1o8K069902>