Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 14 Aug 2018 19:21:31 +0000 (UTC)
From:      Mark Johnston <markj@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r337813 - head/sys/x86/x86
Message-ID:  <201808141921.w7EJLVAa076057@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: markj
Date: Tue Aug 14 19:21:31 2018
New Revision: 337813
URL: https://svnweb.freebsd.org/changeset/base/337813

Log:
  Help ensure that the copy loop doesn't get converted to a memcpy() call.
  
  Reported and reviewed by: kib
  X-MFC with:	r337715
  Sponsored by:	The FreeBSD Foundation

Modified:
  head/sys/x86/x86/ucode.c

Modified: head/sys/x86/x86/ucode.c
==============================================================================
--- head/sys/x86/x86/ucode.c	Tue Aug 14 19:12:45 2018	(r337812)
+++ head/sys/x86/x86/ucode.c	Tue Aug 14 19:21:31 2018	(r337813)
@@ -346,7 +346,7 @@ ucode_load_bsp(uintptr_t free)
 			addr = map_ucode(free, len);
 			/* We can't use memcpy() before ifunc resolution. */
 			for (i = 0; i < len; i++)
-				addr[i] = match[i];
+				addr[i] = ((volatile uint8_t *)match)[i];
 			match = addr;
 
 			if (loader->load(match, false) == 0) {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201808141921.w7EJLVAa076057>