Date: Fri, 12 Sep 2025 14:59:40 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Zhenlei Huang <zlei@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 22238759c57d - main - sys/bus.h: Some style(9) fixes Message-ID: <aMQLLOgeeIhtUgM9@kib.kiev.ua> In-Reply-To: <202509120456.58C4uwVD027045@gitrepo.freebsd.org> References: <202509120456.58C4uwVD027045@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Sep 12, 2025 at 04:56:58AM +0000, Zhenlei Huang wrote: > The branch main has been updated by zlei: > > URL: https://cgit.FreeBSD.org/src/commit/?id=22238759c57d942865cf9d1a355a0d04819eb621 > > commit 22238759c57d942865cf9d1a355a0d04819eb621 > Author: Zhenlei Huang <zlei@FreeBSD.org> > AuthorDate: 2025-09-12 04:55:14 +0000 > Commit: Zhenlei Huang <zlei@FreeBSD.org> > CommitDate: 2025-09-12 04:55:14 +0000 > > sys/bus.h: Some style(9) fixes > > and whitespace cleanup. > > MFC after: 3 days > --- > sys/sys/bus.h | 38 ++++++++++++++++++++------------------ > 1 file changed, 20 insertions(+), 18 deletions(-) > > diff --git a/sys/sys/bus.h b/sys/sys/bus.h > index dda27f4737b2..e7ce152160f8 100644 > --- a/sys/sys/bus.h > +++ b/sys/sys/bus.h > @@ -78,7 +78,7 @@ typedef enum device_property_type { > * The strings are placed one after the other, separated by NUL characters. > * Fields should be added after the last one and order maintained for compatibility > */ > -#define BUS_USER_BUFFER (3*1024) > +#define BUS_USER_BUFFER (3 * 1024) > struct u_device { > uintptr_t dv_handle; > uintptr_t dv_parent; > @@ -247,8 +247,8 @@ typedef struct devclass *devclass_t; > * and may use regular mutexes. However, it is prohibited from > * sleeping on a sleep queue. > */ > -typedef int driver_filter_t(void*); > -typedef void driver_intr_t(void*); > +typedef int driver_filter_t(void *); > +typedef void driver_intr_t(void *); What are the fixes there, specifically? > > /** > * @brief Interrupt type bits. > @@ -476,18 +476,18 @@ int bus_generic_resume(device_t dev); > int bus_generic_resume_child(device_t dev, device_t child); > int bus_generic_setup_intr(device_t dev, device_t child, > struct resource *irq, int flags, > - driver_filter_t *filter, driver_intr_t *intr, > + driver_filter_t *filter, driver_intr_t *intr, > void *arg, void **cookiep); And there? The continuation indent is completely wrong from the style(9) guide, and the change just kept it, there and everywhere.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?aMQLLOgeeIhtUgM9>