Date: Mon, 14 Nov 2011 13:02:35 -0500 From: David Schultz <das@FreeBSD.ORG> To: Dimitry Andric <dim@FreeBSD.ORG> Cc: svn-src-head@FreeBSD.ORG, svn-src-all@FreeBSD.ORG, Stefan Farfeleder <stefanf@FreeBSD.ORG>, David Chisnall <theraven@FreeBSD.ORG>, src-committers@FreeBSD.ORG Subject: Re: svn commit: r227487 - head/include Message-ID: <20111114180235.GA58284@zim.MIT.EDU> In-Reply-To: <4EC0E6C2.4010509@FreeBSD.org> References: <201111131618.pADGIm2n099696@svn.freebsd.org> <20111114082129.GA1596@mole.fafoe.narf.at> <4EC0E6C2.4010509@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Nov 14, 2011, Dimitry Andric wrote: > On 2011-11-14 09:21, Stefan Farfeleder wrote: > > On Sun, Nov 13, 2011 at 04:18:48PM +0000, David Chisnall wrote: > >> Author: theraven > >> Date: Sun Nov 13 16:18:48 2011 > >> New Revision: 227487 > >> URL: http://svn.freebsd.org/changeset/base/227487 > >> > >> Log: > >> The spec says that FILE must be defined in wchar.h, but it wasn't. It > >> is now. Also hide some macros in C++ mode that will break C++ > >> namespaced calls. > >> > >> Approved by: dim (mentor) > > > > I think this change is wrong. Whic spec are you referring to? C99 > > defines FILE only in 7.19.1#2 (stdio.h). In other headers FILE is used > > as parameter type for functions but that does not mean it is exported to > > user space. > > http://pubs.opengroup.org/onlinepubs/007908799/xsh/wchar.h.html It's a niggling detail, but that's an extension to the C standard, so properly speaking, it belongs in an #if __POSIX_VISIBLE >= 200809 || XSI_VISIBLE (or something like that). The formals were struct __sFILE * instead of FILE * for that reason -- see r103177. P.S. You're looking at a very old version of POSIX. Check out: http://pubs.opengroup.org/onlinepubs/9699919799/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111114180235.GA58284>