Date: Thu, 7 Dec 2017 08:10:56 +0000 From: Pietro Cerutti <gahr@FreeBSD.org> To: Joe Marcus Clarke <marcus@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r447981 - in head/ports-mgmt/portlint: . src Message-ID: <20171207081055.xtssqrp5okethfeu@ptrcrt.ch> In-Reply-To: <20171207080421.qijzbigqkbfbezqe@ptrcrt.ch> References: <201708151243.v7FChEAF043279@repo.freebsd.org> <20171207080421.qijzbigqkbfbezqe@ptrcrt.ch>
next in thread | previous in thread | raw e-mail | index | archive | help
--ntonfb6yk5jxaf73 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Dec 7 17 08:04, Pietro Cerutti wrote: > On Aug 15 17 12:43, Joe Marcus Clarke wrote: > > Author: marcus > > Date: Tue Aug 15 12:43:14 2017 > > New Revision: 447981 > > URL: https://svnweb.freebsd.org/changeset/ports/447981 > >=20 > > Log: > > Update to 2.17.12. >=20 > > @@ -3400,6 +3437,11 @@ sub abspathname { > > =20 > > if ($pre =3D~ /MASTER_SITE_SUBDIR/) { > > # MASTER_SITE_SUBDIR lines are ok. > > + $i =3D ''; > > + } > > + if ($s =3D~ /\$\{[^}]*?$i/) { > > + # If we're inside a make variable, we probably do not have > > + # an absolute path. > > $i =3D ''; > > } > > } > >=20 >=20 > Unmatched ) in regex; marked by <-- HERE in m/\$\{[^}]*?/dev/null 2>&1 )= =20 > <-- HERE / at /usr/local/bin/portlint line 3443. >=20 > I think the ? doesn't belong there. No, my analysis was wrong. It's about the contents of the $i variable.=20 Here's why. You can reproduce by portlint -AC in net-im/openfire. i is /var/log/openfire WARN: Makefile: possible use of absolute pathname "/var/log/openfire". i is /var/db/openfire WARN: Makefile: possible use of absolute pathname "/var/db/openfire". i is /dev/null 2>&1 ) Unmatched ) in regex; marked by <-- HERE in m/\$\{[^}]*?/dev/null 2>&1 )=20 <-- HERE / at /usr/local/bin/portlint line 3444. --=20 Pietro Cerutti The FreeBSD Project gahr@FreeBSD.org --ntonfb6yk5jxaf73 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJiBAABCgBMFiEE2m3hBqW4VLhd2G1JrdDTjqGSCJ4FAloo948uFIAAAAAAFQAQ cGthLWFkZHJlc3NAZ251cGcub3JnZ2FockBGcmVlQlNELm9yZwAKCRCt0NOOoZII ntpkEACeE66+w6L4Uf7/RTg5xmLeRgRhcpKIMGKSEfq4N6N90hMKPEkfZeUpskGM s7PBkB+ea5o8pMGAyzdwb2T4/eNzjZYbTe+NFskA7vaPPLW5n8sow/RZtPlOBXZI X4YMsxwO62QbvZfJp7NfPfNXMAQiKsuda8/Ui4LgsUedgE9XKJ2TB2oHYDL2lgxu JpQUAKgnH6aw+COYSSkHjXcWRAIK6VEbUGCJIWPsShvHVsRWmezU+1G0rrAnJjzo eVUoH0ayF2pavtcPopMlWifdqdV1WnCM4YWfAkgjLHYTdeGx2mq6yrTfoRZbO3zC AvY4AocOuEboEdBMX6mv4m476iFvlwIK7v/yO9uO+buoJ1NqhN1UcTiGvtGDSCbO Nth2epmLGbQ7PMjMAc04r+UYRqoA11bQKqzCUsqSal+6UmQM9GiEjukppeDLbIzA LDJuJjXj+EnfOTZpf1nTWf1WLpNz6mLPNxYNF/0h6oXnjNvQtIzPJDV3PKlg8X5R uYKlHwS7Mv1qwufdKQEvpzYtbKFhapnvIoU8M0HsQH8YYnFIN7HNolITFvWU//mJ fGP1v6scfyCF1ul0xnQYIdbNoWYCV2UuEUH5qD4a3rplvDZrj3JJiRtXa8LDXKX8 9Tf1BiPO3P44oSPcsfVlkblxQPWhUKFTsZrfmEfAHhCeAk6i3w== =qRbU -----END PGP SIGNATURE----- --ntonfb6yk5jxaf73--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171207081055.xtssqrp5okethfeu>