Date: Mon, 29 Jan 2007 19:45:22 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Nate Lawson <nate@root.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/geom/eli g_eli.c Message-ID: <20070129184522.GD87767@garage.freebsd.pl> In-Reply-To: <45BE37DC.6080509@root.org> References: <20070128202917.5B67916A5A6@hub.freebsd.org> <45BD82D2.20301@root.org> <20070129175222.GA87767@garage.freebsd.pl> <45BE37DC.6080509@root.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Mon, Jan 29, 2007 at 10:07:24AM -0800, Nate Lawson wrote: > Pawel Jakub Dawidek wrote: > >Hmm, I thought that cold is zeroed before smp_started is set? > > I don't think that's guaranteed. Besides, there's an easier way to fix your problem. Instead of calling kthread_create() from your geom create routine directly, queue a > stub request on the thread taskqueue to call kthread_create(). > > For example, see sys/dev/acpica/acpi_acad.c. We call this from attach() and then the system thread only runs and then calls acpi_acad_init() once all CPUs are > initialized. See sys/sys/taskqueue.h for how to add a task to the system thread taskqueue: > > taskqueue_enqueue(taskqueue_thread, &task); If we want to fix it better, I think GEOM should start (tasting at least) after all CPUs are online. -- Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFFvkDCForvXbEpPzQRAsz4AJwOgS6mpJDRwf9QiNZguPOopfdmiACgnLbT QFJMfX2KQJ1/KbH3w5yEaZw= =9ybj -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070129184522.GD87767>