Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 13 Nov 2018 12:26:50 +0000
From:      Alexey Dokuchaev <danfe@freebsd.org>
To:        Jan Beich <jbeich@freebsd.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r484868 - head/graphics/azpainter
Message-ID:  <20181113122650.GA42216@FreeBSD.org>
In-Reply-To: <36s5-fa3k-wny@FreeBSD.org>
References:  <201811131020.wADAKkDd074298@repo.freebsd.org> <36s5-fa3k-wny@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Nov 13, 2018 at 01:14:23PM +0100, Jan Beich wrote:
> Alexey Dokuchaev <danfe@FreeBSD.org> writes:
> > New Revision: 484868
> > URL: https://svnweb.freebsd.org/changeset/ports/484868
> >
> > Log:
> >   Try to unbreak the build on architectures that still use old GCC as their
> >   system compiler by using contemporary GCC version.
> >   
> >   Tested on:	powerpc
> [...]
> > +.include <bsd.port.pre.mk>
> 
> ARCH is defined in bsd.port.options.mk, so pre/post.mk could've been
> avoided.

I'll look into it, thanks.

> > +.if ${ARCH:Mpowerpc*} || ${ARCH} == sparc64
> > +USE_GCC=	yes
> > +.endif
> 
> Why not USES=compiler:c++11-lang? mips* and riscv64 are also GCC-only atm.

Because seeing "c++11-lang" in pure C program is confusing?  I don't know
much knowledge about those arches so I didn't include them.  It would be
nice to specify "GCC-4.2.1 does not cut it" without having to spell C++11.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20181113122650.GA42216>