Date: Thu, 27 Mar 2003 16:31:02 -0600 (CST) From: Mike Silbersack <silby@silby.com> To: Bosko Milekic <bmilekic@unixdaemons.com> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/conf options src/sys/netinet ip_output.c Message-ID: <20030327163012.F748@odysseus.silby.com> In-Reply-To: <20030327171501.GA18549@unixdaemons.com> References: <200303260452.h2Q4quap015364@www.ambrisko.com> <20030326183351.GJ57674@elvis.mu.org> <20030327013224.P7674@odysseus.silby.com> <20030327165800.GK57674@elvis.mu.org> <20030327171501.GA18549@unixdaemons.com>
next in thread | previous in thread | raw e-mail | index | archive | help
I'll give this a shot when I get time to work on the patch next. If a similar change to m_dup_pkthdr works fine, do you want me to go ahead and commit it? Thanks, Mike "Silby" Silbersack On Thu, 27 Mar 2003, Bosko Milekic wrote: > > See attached. Similar logic may be applied to m_dup_pkthdr(). > > On Thu, Mar 27, 2003 at 05:58:00PM +0100, Maxime Henrion wrote: > > Bosko Milekic wrote: > > > > > > Can you please still use m_gethdr() or m_getcl() to do the allocations > > > in the defragment function? Similarly, for > MCLBYTES, use m_getm(). > > > Don't roll your own. > > > > Please see my reply to Mike for the first version of his patch. He > > couldn't do this because m_dup_pkthdr() has a KASSERT() that makes it > > panic if we have a cluster attached to the mbuf. > > > > Cheers, > > Maxime > > > > -- > Bosko Milekic > bmilekic@unixdaemons.com > bmilekic@FreeBSD.org > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030327163012.F748>