Date: Sun, 9 Nov 2008 04:07:15 -0500 From: "Matteo Riondato" <matteo@freebsd.org> To: "Alexey Dokuchaev" <danfe@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r184780 - head/usr.sbin/cron/crontab Message-ID: <dead9b840811090107k4ca4969ey8f8e1a38299ddea4@mail.gmail.com> In-Reply-To: <20081109084817.GA23323@FreeBSD.org> References: <200811090734.mA97YBld033553@svn.freebsd.org> <20081109084817.GA23323@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Nov 9, 2008 at 3:48 AM, Alexey Dokuchaev <danfe@freebsd.org> wrote:
> On Sun, Nov 09, 2008 at 07:34:11AM +0000, Matteo Riondato wrote:
>>
>> +void
>> +static remove_tmp(int sig)
>> +{
>> + if (tmp_path) {
>> + unlink(tmp_path);
>> + }
>> + exit(ERROR_EXIT);
>> +}
>
> This looks weird: `static' should be on same line as `void' as `static
> void' (so ^remove_tmp would match). It will also always exit with
> ERROR_EXIT, which does not look right, does it?
Sure. I reverted the file back to the previous revision. I got other
comments which suggest I should work on a better version of the patch.
I'll do it later today...
Sorry for the noise.
Best regards
--
Matteo Riondato
FreeBSD Committer (http://www.freebsd.org)
G.U.F.I. Staff Member (http://www.gufi.org)
FreeSBIE Developer (http://www.freesbie.org)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?dead9b840811090107k4ca4969ey8f8e1a38299ddea4>