Date: Sat, 12 Jun 2004 14:15:59 -0400 From: Anish Mistry <mistry.7@osu.edu> To: freebsd-hardware@freebsd.org Cc: Markus Wild <mwild@vianetworks.ch> Subject: Re: Fix for Logitech DiNovo cordless mouse [PATCH] Message-ID: <200406121416.07647.mistry.7@osu.edu> In-Reply-To: <200406121245.i5CCjTOZ011659@smsgw.vianetworks.ch> References: <200406121245.i5CCjTOZ011659@smsgw.vianetworks.ch>
next in thread | previous in thread | raw e-mail | index | archive | help
=2D----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Saturday 12 June 2004 08:45 am, Markus Wild wrote: > Hm, I had a look through the patched files, and one thing that sprung > to my eyes: the FreeBSD hid_report_size(() function is currently used > to both return the size of a report, as well as setting the device > report ID (the ID parameter is of type "out"). This ID is later used > to match incoming reports to the device. With the suggested > changes, this parameter changes to being of type "in", i.e. the > function no longer returns the ID information to the calling function. > This would certainly generate a compile time warning (if not error) > for ums.c, and while uhid.c has been syntactically changed, I now see > no place where sc->sc_iid, sc->sc_oid, sc->sc_fid would be initialized > after applying the change. I assume the NetBSD code in itself is sound, > so perhaps we're just missing additional files now that would also need > to be changed for FreeBSD? > You're right, I missed a couple files. This is starting to turn a bit messy= ,=20 but it'll be better to sync it up now rather than later. I'm going to try = to=20 get a better patch this weekend. =2D --=20 Anish Mistry =2D----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAy0hmxqA5ziudZT0RAikEAJoDzFMcgyXtiZ3xWiSepVVgJzFiegCgqgsr JoH9RSdTshG5Z5F18HS3w2Y=3D =3DZGKF =2D----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200406121416.07647.mistry.7>