Date: Tue, 20 Mar 2012 14:57:24 -0400 From: John Baldwin <jhb@freebsd.org> To: Jason Wolfe <nitroboost@gmail.com> Cc: freebsd-net@freebsd.org, Adrian Chadd <adrian@freebsd.org>, Hooman Fazaeli <hoomanfazaeli@gmail.com> Subject: Re: Intel 82574L interface wedging - em7.3.2/8.2-STABLE Message-ID: <201203201457.24776.jhb@freebsd.org> In-Reply-To: <CAAAm0r0JxpHdq9CS=uwWysojXv_K-iT_NOb_fTeKAiAE_w8nbQ@mail.gmail.com> References: <CAAAm0r3Qj%2B2rf8cx54bcyAXGQezcE8J=xXYPq4W-jDy75r8qew@mail.gmail.com> <201203151417.04507.jhb@freebsd.org> <CAAAm0r0JxpHdq9CS=uwWysojXv_K-iT_NOb_fTeKAiAE_w8nbQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday, March 20, 2012 1:45:32 pm Jason Wolfe wrote: > On Thu, Mar 15, 2012 at 11:17 AM, John Baldwin <jhb@freebsd.org> wrote: > > On Sunday, March 11, 2012 3:47:07 am Hooman Fazaeli wrote: > >> On 3/11/2012 5:31 AM, Adrian Chadd wrote: > >> > Are you able to post the patch here? > >> > Maybe Jack can look at what's going on and apply it to the latest > >> > intel ethernet driver. > >> > > >> > > >> > Adrian > >> > > >> > >> Below is the patch for if_em.c (7.2.3). It simply checks driver's > >> queue status when the link state changes (inactive -> active) and > >> start transmit task if queue(s) are not empty. > >> > >> It also contains stuff I have added to compile on 7 plus some code > >> for test and diagnostics. > > > > Hmm, so I have yet to test this, but I found several bugs related to transmit > > in em(4) and igb(4) recently just reading the code. (Mostly unnecessary > > scheduling of tasks for transmit.) I've included your change of restarting > > TX when link becomes active. I've also updated it to fix resume for em > > and igb to DTRT when buf_ring is used, and to not include old-style start > > routines at all when using multiq. It is at > > http://www.freebsd.org/~jhb/patches/e1000_txeof2.patch > > > > -- > > John Baldwin > > John/Hooman, > > Thank for the patch sirs, so far it does look like it did the trick. > I'll know for certain here in a few days if I'm still in the clear. > I'm guessing after it goes through some more testing it'll be too late > to slip it into 8.3? Yes, this is too late for 8.3, but thanks for testing! -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201203201457.24776.jhb>