Date: Wed, 21 Oct 2015 20:46:07 -0600 From: Warner Losh <imp@bsdimp.com> To: Alexander Kabaev <kabaev@gmail.com> Cc: Ed Maste <emaste@FreeBSD.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r289728 - head Message-ID: <58F602B5-1F88-48C1-B248-0328437E9D8B@bsdimp.com> In-Reply-To: <20151021214550.70b25f13@kan> References: <201510220132.t9M1WBW9087666@repo.freebsd.org> <20151021214550.70b25f13@kan>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On Oct 21, 2015, at 7:45 PM, Alexander Kabaev <kabaev@gmail.com> wrote: > > On Thu, 22 Oct 2015 01:32:11 +0000 (UTC) > Ed Maste <emaste@FreeBSD.org> wrote: > >> Author: emaste >> Date: Thu Oct 22 01:32:11 2015 >> New Revision: 289728 >> URL: https://svnweb.freebsd.org/changeset/base/289728 >> >> Log: >> Warn that NOCLEAN is deprecated - use NO_CLEAN instead >> >> NO_CLEAN has been the correct spelling for over a decade. >> >> Modified: >> head/Makefile.inc1 >> >> Modified: head/Makefile.inc1 >> ============================================================================== >> --- head/Makefile.inc1 Thu Oct 22 01:04:31 2015 >> (r289727) +++ head/Makefile.inc1 Thu Oct 22 01:32:11 >> 2015 (r289728) @@ -128,6 +128,7 @@ SUBDIR+=etc >> .endif # !empty(SUBDIR_OVERRIDE) >> >> .if defined(NOCLEAN) >> +.warning NOCLEAN option is deprecated. Use NO_CLEAN instead. >> NO_CLEAN= ${NOCLEAN} >> .endif >> .if defined(NO_CLEANDIR) > > > For some definition of 'correct'. It definitely is not for those who > have -DNOCLEAN wired into their finger memory and above mentioned > decade did not help with that any. > > I think some of the common spellings were left as is in great NO_<foo> > revolution for a reason and I see no reason why the sudden itch to > change that. There’s no sudden itch. We’ve been scratching at the NO_<foo> irritants in the tree regularly for years, and more regularly in the past year. I eliminated a boatload of them 9 months ago. More will go away. Warner [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJWKE3wAAoJEGwc0Sh9sBEAci8QAN7AFfFce84BmMbrBZ2dV+hH hUuOjT9dZIMeMUZT2EtSXY0VDsSmMnfvr3cwY6ATS9HcqiveXI8ooFm+Iv/Th/Kl OQE1Aq02OQTdd8qyTe1JQVjWOPCM1DMtGSozpucaBG++2Dc2jOWuIAYt1jzd1hHN 1DtNJmaSWLYkO2Xx+C8RqewWEPw7DvpbINtEBXRX60FL1k+aUQ+WX2tqI6ME50vt OwMaikqu3TVmletoEqE0B0EZyZ2+CxxoZE/jLo7OiDaeP2HqvD+sGHggIiqa96U9 scnwx9oaV6NdlMgF1rupYxshu5Y3oL0OtB3gqVNPueYKh5EU+iTEdM1f9SlexaKJ MQWlqBcYmXdyIdkyVW8I2YEs3XX8DcOGZDA/dll9JSkAlF3Sf/6GWzWP99qesefO G86M9gEbmtcKaNyo6S4RosIcfOpF/VtCiA069OjRgkQqqtUOYUXEK9MATJGBn8Y6 tpErMup2CIsMFOwJtdV97dw+rvqBCGxE5t6ZRpws1xoLZoIIr4rvyoEspeu9IQNi qd1iDgyTJRiauIXEhG2B+OdKpF/bwO2T8X8CVN7xLppmwrZxEYsivuJ5KSa3ytIb q0E3eCcMMkg6latFmi5QAFvnZ8+13wA39q1t2z4zQ2TrfALdQ4MSYZxwHnxGd9tB OAv5witMlpccZdGsL+HU =PKFD -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?58F602B5-1F88-48C1-B248-0328437E9D8B>