Date: Fri, 4 Jul 2008 13:28:47 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Pietro Cerutti <gahr@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/editors/codelite Makefile distinfo pkg-plist ports/editors/codelite/files patch-configure Message-ID: <20080704132847.GA21540@FreeBSD.org> In-Reply-To: <200807031840.m63Ier8s004961@repoman.freebsd.org> References: <200807031840.m63Ier8s004961@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jul 03, 2008 at 06:40:53PM +0000, Pietro Cerutti wrote:
> gahr 2008-07-03 18:40:53 UTC
>
> FreeBSD ports repository
>
> Modified files:
> editors/codelite Makefile distinfo pkg-plist
> editors/codelite/files patch-configure
> Log:
> - Update to 1.0
Some quick observations:
- You've left PORTREVISION, which is porbably unnecessary
- Bad indent of WRKSRC assignment
- Ditto for USE_WX
- You've dropped GNU_CONFIGURE, and instroduced custom do-configure
target which pretty much mimics default action. If configure script
is not GNU autotools generated and one cannot assume it would
understand some common options (--prefix et al.), there's
HAS_CONFIGURE knob for that in bpm
- Most directories are created with mkdir, some with install -d, which
introduces certain inconsistency
- Ditto for trailing slashes for target directory names during
installation (also, in pkg-plist)
- (cd ${WRKSRC}/Runtime/sdk/include/UnitTest++ && ${COPYTREE_SHARE} \*
^^
superfluous space here ------------------------++
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080704132847.GA21540>