Date: Mon, 14 Dec 1998 06:53:00 +0100 (CET) From: List User <listuser@netspace.net.au> To: freebsd-current@FreeBSD.org Message-ID: <199812140553.GAA05438@doorway.home.lan>
next in thread | raw e-mail | index | archive | help
Newsgroups: freebsd.current
Path: root
From: Nate Williams <nate@mt.sri.com>
Subject: Re: minor vipw/pwd_mkdb changes commited
Content-Type: text/plain; charset=us-ascii
Received: by mt.sri.com (SMI-8.6/SMI-SVR4)
id NAA06177; Sun, 13 Dec 1998 13:48:04 -0700
To: Matthew Dillon <dillon>
Sender: owner-freebsd-current@FreeBSD.ORG
Content-Transfer-Encoding: 7bit
Organization: Private News Host
Precedence: bulk
Message-ID: <199812132048.NAA06177@mt.sri.com>
X-Mailer: VM 6.34 under 19.16 "Lille" XEmacs Lucid
References: <199812130203.SAA14359@apollo.backplane.com>
Delivered-To: vmailer-current@freebsd.org
X-Uidl: 00a9774843d396711f353f1597ddbc0a
X-Loop: FreeBSD.ORG
Mime-Version: 1.0
In-Reply-To: <199812130203.SAA14359@apollo.backplane.com>
Cc: freebsd-current
Date: Sun, 13 Dec 1998 20:48:04 GMT
> I've made a few minor fixes to vipw and pwd_mkdb to handle a
> master.passwd race condition (note: there are no security issues
> with the race).
I *think* I fixed this is Auguest already, didn't I?
nate 1998/07/16 10:18:30 PDT
Modified files:
usr.sbin/pw edgroup.c fileupd.c pw.c
Log:
Fix race condition in pw caused by multiple instances of pwd_mkdb
being
run at the same time.
Notes:
The fileupdate function is still somewhat broken. Instead of
returning a failure code if it can't modify the original file it
renames the .new file and continues as though nothing is wrong.
This will cause the lock on the original file to be lost and could
lead to a similar race condition. I left that portion of the code
alone since I feel that the maintainer of the code would have a
better concept of how he wants to handle errors in that function
than I do.
PR: bin/6787
Submitted by: Craig Spannring <cts@internetcds.com>
If not, will these changes conflict with the above changes?
Nate
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199812140553.GAA05438>