Date: Tue, 7 Feb 1995 14:34:20 -0500 From: Garrett Wollman <wollman@halloran-eldar.lcs.mit.edu> To: Bruce Evans <bde@zeta.org.au> Cc: CVS-commiters@freefall.cdrom.com, cvs-usrsbin@freefall.cdrom.com Subject: Re: cvs commit: src/usr.sbin/lsdev i386.c Message-ID: <9502071934.AA28699@halloran-eldar.lcs.mit.edu> In-Reply-To: <199502071918.GAA02064@godzilla.zeta.org.au> References: <199502071918.GAA02064@godzilla.zeta.org.au>
next in thread | previous in thread | raw e-mail | index | archive | help
<<On Wed, 8 Feb 1995 06:18:58 +1100, Bruce Evans <bde@zeta.org.au> said: > I asked Stefan to think about including less goop in <machine/devconf.h>. > This resulted in the above commit. But the above commit was wrong because > PCI_INTERNAL_LEN is not used directly by i386.c; it is apparently required > for <machine/devconf.h> to be self-contained. This was fixed before you > looked at the sources. Hmmm. I don't belong to that religion that says that no header files should ever include other header files and it's the responsibility for the poor programmer to make sure that every program includes every header file in the universe directly in case it's needed somewhere. -GAWollman -- Garrett A. Wollman | Shashish is simple, it's discreet, it's brief. ... wollman@lcs.mit.edu | Shashish is the bonding of hearts in spite of distance. Opinions not those of| It is a bond more powerful than absence. We like people MIT, LCS, ANA, or NSA| who like Shashish. - Claude McKenzie + Florent Vollant
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9502071934.AA28699>