Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 8 Jun 2009 09:13:16 +0000 (UTC)
From:      Kip Macy <kmacy@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-user@freebsd.org
Subject:   svn commit: r193697 - user/kmacy/releng_7_2_fcs/sys/dev/cxgb
Message-ID:  <200906080913.n589DGkA021879@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kmacy
Date: Mon Jun  8 09:13:16 2009
New Revision: 193697
URL: http://svn.freebsd.org/changeset/base/193697

Log:
  comment on inefficiency in t3_encap

Modified:
  user/kmacy/releng_7_2_fcs/sys/dev/cxgb/cxgb_sge.c

Modified: user/kmacy/releng_7_2_fcs/sys/dev/cxgb/cxgb_sge.c
==============================================================================
--- user/kmacy/releng_7_2_fcs/sys/dev/cxgb/cxgb_sge.c	Mon Jun  8 08:26:13 2009	(r193696)
+++ user/kmacy/releng_7_2_fcs/sys/dev/cxgb/cxgb_sge.c	Mon Jun  8 09:13:16 2009	(r193697)
@@ -1404,6 +1404,11 @@ t3_encap(struct sge_qset *qs, struct mbu
 			cbe->cntrl = htonl(cntrl);
 			cbe->len = htonl(segs[i].ds_len | 0x80000000);
 			cbe->addr = htobe64(segs[i].ds_addr);
+			/*
+			 * 62% of function time is spent on the following - need to
+			 * calculate the value to be stored in an intermediate
+			 * and then do a direct update
+			 */
 			txd->flit[fidx] |= htobe64(1 << 24);
 		}
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200906080913.n589DGkA021879>