Date: Fri, 12 Jun 2015 21:13:35 -0400 From: Alexander Kabaev <kabaev@gmail.com> To: Marcel Moolenaar <marcel@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r284198 - head/bin/ls Message-ID: <20150612211335.2d522cef@kan> In-Reply-To: <20150612204309.11dd3391@kan> References: <201506100127.t5A1RdX6051959@svn.freebsd.org> <20150612204309.11dd3391@kan>
next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_/UbDxBEjN6nq2tucYQ3BhEDR Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Fri, 12 Jun 2015 20:43:09 -0400 Alexander Kabaev <kabaev@gmail.com> wrote: > On Wed, 10 Jun 2015 01:27:39 +0000 (UTC) > Marcel Moolenaar <marcel@FreeBSD.org> wrote: >=20 > > Author: marcel > > Date: Wed Jun 10 01:27:38 2015 > > New Revision: 284198 > > URL: https://svnweb.freebsd.org/changeset/base/284198 > >=20 > > Log: > > Convert ls(1) to use libxo(3). > > =20 > > Obtained from: Phil Shafer <phil@juniper.net> > > Sponsored by: Juniper Networks, Inc. > >=20 > <SKIP> >=20 > This broke all code that pipes output of the ls command to pipeline, > such as 'ls | wc -l'. ls never exits and never output anything. Is > there any purpose to libxo other than breaking stuff, which it > achieves so splendidly? >=20 Just to clarify, this happens because libxo cannot display file names in encodings current locate cannot handle. xo_format_string_direct function then spins indefinitely trying to call xo_failure(xop, "invalid mbs char: %02hhx", *cp) over and over, which, of course, produces nothing and does not advance the cp pointer either, resulting in apparent ls hang. --=20 Alexander Kabaev --Sig_/UbDxBEjN6nq2tucYQ3BhEDR Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJVe4O/XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRDNUY3RDk5NTk5QjY0MUUxM0M1MTU2OTEw NzEzMjI5OTkyNzkyRTdFAAoJEAcTIpmSeS5+x48P/2HUQs/T5vIrCJNeybV7N3ub XHN1/Q9W2iQvOL2JbST9VZOva/D1Xlzm+Xl4RE/q5IbxyKcZOZrphY98QFEL7VGN WM9FydxBKqqKpo+bpl2/g1piHtIbMMQajAGV/l931bfvKu80Rmwes1z8gjyrmKeA btvYZldHpZFE1Z283KJP4ubhuobLWirV+fLY1mzcMzQ9ZtNHfSOII9oicbMcb/K1 pH1LmzlaLFwPq8VYpd+spKRyKDPsnM0An2xaou4PRowFkG/ibSVbZjScVbHp0eml c7qWFKe26bTNqJnZ+Qz4Ca9JYTb7yC+FRpwMEo0YG68tgDMZ9si+Pl+8LHmCjTtG LHQ1GxAuYVF/8aawJNM/d4zrQV7RrdI1aOxjZuNyS9JjOlFnsNDYNNDXlD/4HlMV bOhVA1KV0T45no9pukgyQKJZh2KNYjwgKnA+KNf5xobkOV5n1wkOUPRZBzD/zQod vnqaKWHRoQWtO+Gg08yxtfSU2zsFNBIWoODPCA9EbmIaMDFjS55NYGNu/on4Atzp ovVNBmg1i7fnY22ZSnR4cQcagjTvQZp/JNMipGtn4ekNInO8Aw0SEjQgoiiCMDR2 u7DwOtiJjRxg3Tr1kuSfCE+BjaSWKQ2N+w6d6MjEF3TVNUenABU83rKECEE4gGY7 dcFUDQBMchrTOCR/8Yjc =lIGd -----END PGP SIGNATURE----- --Sig_/UbDxBEjN6nq2tucYQ3BhEDR--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150612211335.2d522cef>