Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 13 Oct 2006 15:19:44 -0700
From:      Doug Barton <dougb@FreeBSD.org>
To:        John Baldwin <jhb@freebsd.org>
Cc:        cvs-src@freebsd.org, src-committers@freebsd.org, Ruslan Ermilov <ru@freebsd.org>, cvs-all@freebsd.org
Subject:   Re: cvs commit: src/share/zoneinfo africa antarctica asia australasia backward etcetera europe factory leapseconds northamerica southamerica systemv yearistype.sh zone.tab
Message-ID:  <45301100.9040908@FreeBSD.org>
In-Reply-To: <200610131615.09414.jhb@freebsd.org>
References:  <200610131751.k9DHph6C076014@repoman.freebsd.org> <20061013195841.GB28074@rambler-co.ru> <200610131615.09414.jhb@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
John Baldwin wrote:

>> Part of the reason I didn't want to do it is that on RELENG_4
>> it also requires more changes (like a makefile and etc/mtree).
>> I think you just broke the install on RELENG_4 with this
>> commit.

I have a working RELENG_4 system, and I tested the install before 
committing. The main effect of the Makefile changes on the install is 
to move the systemv file behind the OLDTIMEZONES define. I didn't do 
that because I thought it would be a POLA violation.

The other install related change in the Makefile was using zic -m, but 
since that fix (I think rightly) hasn't been backported past RELENG_6, 
I didn't merge that change either. For both of these changes, the same 
goes for RELENG_5 btw.

> Yeah, there is an mtree and Makefile change, but I'd actually rather
> us fix RELENG_4 to work with the new files.  I already merged back
> those changes at my last job, and my new one has the local changes
> as well (well, we only have the Makefile changes, not the mtree
> ones, but I remember doing the mtree one last year).

The mtree change I think you're referring to (regarding Argentina) was 
committed by wollman on 2004/12/3. The mtree file in RELENG_4 is the 
same as HEAD for the zoneinfo section.

So like I said, I don't think anything is actually broken here, but if 
someone sees something broken that I don't, please feel free to fix 
it, I'm going to be afk for a while.

hth,

Doug

PS, I really hope that people didn't equate "wasn't hard to do" with 
"flying blind" here ...

-- 

     This .signature sanitized for your protection



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?45301100.9040908>