Date: Fri, 9 Nov 2012 12:19:17 -0500 From: Eitan Adler <eadler@freebsd.org> To: Bryan Drewery <bdrewery@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r306199 - in head/devel/readline: . files Message-ID: <CAF6rxg=EUxNX2-GuZerxdMEM8UFoVPZyFSiZH%2BCxWyWepDV5-A@mail.gmail.com> In-Reply-To: <509D3945.3070101@FreeBSD.org> References: <201210201559.q9KFx4mA060483@svn.freebsd.org> <509D216D.4020809@FreeBSD.org> <509D3945.3070101@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 9 November 2012 12:11, Bryan Drewery <bdrewery@freebsd.org> wrote: > On 11/9/2012 9:29 AM, Bryan Drewery wrote: >> On 10/20/2012 10:59 AM, Eitan Adler wrote: >>> Author: eadler >>> Date: Sat Oct 20 15:59:04 2012 >>> New Revision: 306199 >>> URL: http://svn.freebsd.org/changeset/ports/306199 >>> >>> Log: >>> Convert to OptionsNG >>> Remove stale patch (seems to not matter anymore with recent gcc versions) >>> >>> Feature safe: yes >>> >>> Deleted: >>> head/devel/readline/files/support_shobj-conf.diff >>> Modified: >>> head/devel/readline/Makefile >>> >>> Modified: head/devel/readline/Makefile >>> ============================================================================== >>> --- head/devel/readline/Makefile Sat Oct 20 15:55:45 2012 (r306198) >>> +++ head/devel/readline/Makefile Sat Oct 20 15:59:04 2012 (r306199) >>> @@ -20,12 +20,8 @@ MAN3= readline.3 history.3 >>> >>> .include <bsd.port.pre.mk> >>> >>> -.if ${ARCH} == "sparc64" >>> -EXTRA_PATCHES+= ${FILESDIR}/support_shobj-conf.diff >>> -.endif >>> - >>> pre-configure: >>> -.if !defined(WITHOUT_TERMCAP) >>> +.if ${PORT_OPTIONS:MNLS} >>> ${REINPLACE_CMD} "s/SHOBJ_LDFLAGS =/SHOBJ_LDFLAGS = -ltermcap/" ${WRKSRC}/shlib/Makefile.in >>> .endif >>> >> >> This effectively changes TERMCAP from being default to now not-default. This should have been fixed in r306201. If I missed something please fix it w/ my approval. I won't have time to look into this for some time. FWIW, I've also received one report that this revision broke readline on i386, but I can't reproduce on my VM, and I've asked others to reproduce, and they can not. If anyone else is having trouble with readline please let me know. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxg=EUxNX2-GuZerxdMEM8UFoVPZyFSiZH%2BCxWyWepDV5-A>