Date: Wed, 18 Jul 2012 06:38:06 -0700 From: Trent Nelson <trent@snakebite.org> To: Warren Block <wblock@wonkity.com>, Eitan Adler <lists@eitanadler.com> Cc: David Magda <dmagda@ee.ryerson.ca>, "freebsd-stable@freebsd.org" <freebsd-stable@freebsd.org> Subject: Re: The MFC process... Message-ID: <CC2C3181.32C29%trent@snakebite.org> In-Reply-To: <alpine.BSF.2.00.1207171234000.77737@wonkity.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 7/17/12 2:40 PM, "Warren Block" <wblock@wonkity.com> wrote: >On Tue, 17 Jul 2012, Eitan Adler wrote: > >> On 17 July 2012 10:10, Warren Block <wblock@wonkity.com> wrote: > >>> Unless there was no PR. Which brings up the question of how can we >>>query >>> for MFCs now? For example, how many MFCs are past due? What is the >>>oldest >>> one? >> >> svn mergeinfo --show-revs eligible > >But those are just commits that svn sees as eligible for a merge, not >ones with an actual "MFC after" message. Those two concepts should be considered synonymous :-) >From a fitting-svn-best-practices-to-freebsd-development-style perspective, this is what developers should be doing: 1. If a change is eligible for MFC, obviously indicate that in the log message as usual. So, no change from how development is done now. 2. If a change is not eligible for MFC, or should never be merged back to stable for whatever reason, it should be blocked in such a way that svn will know never to suggest merging it. This would be done as follows: % cd /src/head [make change] % svn ci -m "..." Committed revision r890101 % cd /src/stable/9 % svn st [ should return nothing -- I.e. no local mods ] % svn merge --record-only -c890101 https://svn.freebsd.org/base/head . ... % svn ci -m "Blocking r890101." . If this approach is adopted by all developers -- `svn mergeinfo --show-revs eligible` will always do exactly what you want: show revisions eligible for MFC that have not yet been merged. You can run this command at any level, too. I did it at sys/dev/isp, because that's all I cared about, but you can go as deep or as shallow within the tree as you like. It would also be trivial to whip up a script that runs it at the top level, then for each rev, filter it based on committer. That would achieve Eitan's desired goal of "tell me all my outstanding head/ commits I need to MFC". Regards, Trent.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CC2C3181.32C29%trent>