Date: Wed, 29 Nov 2017 10:06:03 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Bruce Evans <brde@optusnet.com.au> Cc: Edward Tomasz Napierala <trasz@freebsd.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r326314 - in head/sys: ddb kern sys Message-ID: <20171129100603.GA30636@FreeBSD.org> In-Reply-To: <20171129200224.A930@besplex.bde.org> References: <201711281253.vASCrtlB071488@repo.freebsd.org> <20171129030035.W2283@besplex.bde.org> <20171129065701.GB71839@FreeBSD.org> <20171129200224.A930@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Nov 29, 2017 at 08:52:04PM +1100, Bruce Evans wrote:
> On Wed, 29 Nov 2017, Alexey Dokuchaev wrote:
> ...
> X Index: kern/subr_kdb.c
> X ===================================================================
> X --- kern/subr_kdb.c (revision 326310)
> X +++ kern/subr_kdb.c (working copy)
> X @@ -224,7 +224,7 @@
> X return (0);
> X }
> X
> X -void
> X +static void
> X kdb_panic(const char *msg)
> X {
> X
> X @@ -232,7 +232,7 @@
> X panic("%s", msg);
> X }
> X
> X -void
> X +static void
> X kdb_reboot(void)
> X {
>
> These changes are problematic. They don't compile, since the functions
> are still declared as implicit-extern in <sys/kdb.h>. More seriously,
> if these functions can be static because they are only called from
> kdb_alternate_break_internal(), then all calls to them are broken since
> "alternate" "break"s are broken (more broken than their name). They
> are done from interrupt handlers where it is invalid to call almost any
> function for the "fast" interrupt handler case (serial console drivers)
> and invalid to call most functions in the normal interrupt handler case
> (syscons and vt). [...]
Yes, I was already told that they are part of public KPI and thus cannot
be easily removed. This issue is to be discussed separately.
> The style fixes are correct.
Thanks; I've already got approval from bapt@ for those and intend to
commit them shortly.
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171129100603.GA30636>