Date: Tue, 18 May 2010 00:39:30 -0700 From: Alfred Perlstein <alfred@freebsd.org> To: Doug Barton <dougb@FreeBSD.org> Cc: freebsd-net@freebsd.org Subject: Re: Patch for ip6_sprintf(), please review Message-ID: <20100518073930.GD6175@elvis.mu.org> In-Reply-To: <4BF045C9.1040906@FreeBSD.org> References: <20100516062211.GC6175@elvis.mu.org> <4BF045C9.1040906@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Thank you Doug, I will be committing this shortly. * Doug Barton <dougb@FreeBSD.org> [100516 12:21] wrote: > Someone at work has been reading > http://tools.ietf.org/html/draft-ietf-6man-text-addr-representation :) > > This change follows the rules in that draft which will become and RFC as > soon as it finishes winding its way through the process, so I am > supportive of the change you are proposing. > > > Doug > > On 5/15/2010 11:22 PM, Alfred Perlstein wrote: > > Hello, > > > > The following patch seems appropriate to apply > > to fix the kernel ip6_sprintf() function. > > > > What it is doing is ensuring that when we > > abbreviate addresses that the longest string > > of zeros is shortend, not the first run of > > zeros. > > > > Our internal commit log is: > > problem: > > Unification of IPv6 address representation > > fix: > > recommended format of text representing an IPv6 address > > is summarized as follows. > > > > 1. omit leading zeros > > > > 2. "::" used to their maximum extent whenever possible > > > > 3. "::" used where shortens address the most > > > > 4. "::" used in the former part in case of a tie breaker > > > > 5. do not shorten one 16 bit 0 field > > > > 6. use lower case > > > > Present code in ip6_sprintf() is following rules 1,2,5,6. > > Adding fix for following other rules also.For following > > rules 3 and 4, finding out the index where to replace zero's > > with '::' and using that index. > > References: > > http://tools.ietf.org/html/draft-ietf-6man-text-addr-representation-04.html > > > > > > Diff is attached in text format. > > > > > > > > > > _______________________________________________ > > freebsd-net@freebsd.org mailing list > > http://lists.freebsd.org/mailman/listinfo/freebsd-net > > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" > > > > -- > > ... and that's just a little bit of history repeating. > -- Propellerheads > > Improve the effectiveness of your Internet presence with > a domain name makeover! http://SupersetSolutions.com/ > > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" -- - Alfred Perlstein .- AMA, VMOA #5191, 03 vmax, 92 gs500, 85 ch250, 07 zx10 .- FreeBSD committer
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100518073930.GD6175>