Date: Wed, 17 Aug 2016 17:21:15 +0200 From: Hans Petter Selasky <hps@selasky.org> To: =?UTF-8?Q?Dag-Erling_Sm=c3=b8rgrav?= <des@des.no> Cc: Slawa Olhovchenkov <slw@zxy.spb.ru>, Nathan Whitehorn <nwhitehorn@freebsd.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r304142 - head/usr.sbin/bsdinstall/partedit Message-ID: <a033b356-b4ca-e810-94d0-d6b0ef83e3ab@selasky.org> In-Reply-To: <86shu34erp.fsf@desk.des.no> References: <201608150930.u7F9UL1V069576@repo.freebsd.org> <e3454e8e-5d98-5bec-21de-8ea0db2b9b08@freebsd.org> <861t1n6749.fsf@desk.des.no> <581c856c-826b-529e-c9c6-a397fb679708@freebsd.org> <20160817144944.GM22212@zxy.spb.ru> <4a28f419-5293-0753-068d-1e07ddb01c2d@selasky.org> <86shu34erp.fsf@desk.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On 08/17/16 17:05, Dag-Erling Smørgrav wrote: > Hans Petter Selasky <hps@selasky.org> writes: >> Not sure if it is an issue, but what will happen if a magic disk has a >> size less than 4K and uses a block size of 512bytes and the disk >> alignment gets rounded up to 4K. Will any of logic in this patch fail >> or hang? > > What is a magic disk, and why would you want to install FreeBSD on a > drive with less than 4096 bytes available? > Hi, My intention is not to install FreeBSD on a 3K disk. My question is pure mathematical, if the bsdinstall will segfault, division by zero or anything like that, if one should try to install FreeBSD on a 3K disk, because you round up the size of the disk to be bigger than it actually is. Should there be a check for too small disks in there? --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a033b356-b4ca-e810-94d0-d6b0ef83e3ab>