Date: Fri, 21 Nov 2014 22:16:01 +0100 From: Roman Divacky <rdivacky@vlakno.cz> To: Bruce Evans <brde@optusnet.com.au> Cc: svn-src-head@freebsd.org, Dag-Erling Sm??rgrav <des@des.no>, svn-src-all@freebsd.org, "Bjoern A. Zeeb" <bz@freebsd.org>, src-committers@freebsd.org Subject: Re: svn commit: r274340 - in head/sys: crypto/rijndael dev/random geom/bde Message-ID: <20141121211601.GA47019@vlakno.cz> In-Reply-To: <20141111223756.F3519@besplex.bde.org> References: <201411100944.sAA9icnN061962@svn.freebsd.org> <3C962D07-3AAF-42EA-9D3E-D8F6D9A812B0@FreeBSD.org> <86sihq5a2v.fsf@nine.des.no> <20141111223756.F3519@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Nov 11, 2014 at 10:48:36PM +1100, Bruce Evans wrote: > On Tue, 11 Nov 2014, [utf-8] Dag-Erling Smørgrav wrote: > > > "Bjoern A. Zeeb" <bz@FreeBSD.org> writes: > >> This fails to compile on all gcc platforms. > >> > >> cc1: warnings being treated as errors > >> /scratch/tmp/bz/head.svn/sys/modules/geom/geom_bde/../../../crypto/rijndael/rijndael-api-fst.c: > >> In function 'rijndael_padEncrypt': > >> /scratch/tmp/bz/head.svn/sys/modules/geom/geom_bde/../../../crypto/rijndael/rijndael-api-fst.c:236: > >> warning: cast discards qualifiers from pointer target type > >> [...] > > > > The code is quite clearly wrong. Why doesn't clang complain? > > -Wcast-qual is broken (has no effect) with clang. This is incompatible > with gcc and defeats the reason of existence of -Wcast-qual. I implemented -Wcast-qual in clang. We might want to backport it to our 3.4 (3.5 when it's imported), to prevent breakages like this in future. http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20141117/118946.html Roman
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141121211601.GA47019>