Date: Thu, 16 Sep 2004 04:07:09 -0000 From: Max Laier <max@love2party.net> To: pf4freebsd@freelists.org Subject: [pf4freebsd] Re: if_fxp.c.patch Message-ID: <200406220143.05302.max@love2party.net> In-Reply-To: <40D760E5.7000903@nipsi.de> References: <40D760E5.7000903@nipsi.de>
next in thread | previous in thread | raw e-mail | index | archive | help
--Boundary-02=_JK31Ap8gWGBAVmC
Content-Type: text/plain;
charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
On Tuesday 22 June 2004 00:27, Dennis Berger wrote:
> Hi,
> today I tried the fxp driver patch and run into a kernelpanic if altq is
> enabled.
> I guess it's something strange with the locking cause the debugger stops =
at
> fxp_start_body();
> this is exactly the point where a lock is needed, or whatever there
> happens...
>
> pyun discovered similar problems months ago, he fixed it by modifying
> the LOCK macro.
> to something like this
>
> #define MY_LOCK do { \
> if(!mtx_owned(&lock) \
> mtx_lock(&lock); \
> } while(0)
> and
> #define MY_UNLOCK do { \
> if(mtx_owned(&lock)); \
> mtx_unlock(&lock); \
> } while(0)
>
> I don't know why he have to check if the lock is held...
Neither do I, but maybe you can provide a complete trace of this panic so w=
e=20
can find the real problem instead of fixing the symptoms? Moreover, if ther=
e=20
is a panic *in* fxp_start_body that means that we fail the mtx_assert (i.e.=
=20
the lock was not properly acquired), above fix will not help it.
Please provide the complete (function names are enough for a start) trace f=
rom=20
that panic in order to give me an idea of the panic. Please also tell me wh=
at=20
kind of queues you have set up.
Thanks.
=2D-=20
Best regards, | mlaier@freebsd.org
Max Laier | ICQ #67774661
http://pf4freebsd.love2party.net/ | mlaier@EFnet
--Boundary-02=_JK31Ap8gWGBAVmC
Content-Type: application/pgp-signature
Content-Description: signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)
iD8DBQBA13KJXyyEoT62BG0RAlmIAJ4y+uNPTt++VEgtvqJsSBwL0D1doACdF/Za
7QZu2TU034t2PI5xjjvGfv8=
=3hmr
-----END PGP SIGNATURE-----
--Boundary-02=_JK31Ap8gWGBAVmC--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200406220143.05302.max>