Date: Fri, 30 Dec 2005 00:06:05 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vfs_subr.c Message-ID: <20051229230604.GA22411@garage.freebsd.pl> In-Reply-To: <200512292252.jBTMq9FQ087829@repoman.freebsd.org> References: <200512292252.jBTMq9FQ087829@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Thu, Dec 29, 2005 at 10:52:09PM +0000, Pawel Jakub Dawidek wrote:
+> pjd 2005-12-29 22:52:09 UTC
+>
+> FreeBSD src repository
+>
+> Modified files:
+> sys/kern vfs_subr.c
+> Log:
+> Print a warning when we miss vinactive() call, because of race in vget().
+> The race is very real, but conditions needed for triggering it are rather
+> hard to meet now.
+> When gjournal will be committed (where it is quite easy to trigger) we need
+> to fix it.
+>
+> For now, verify if it is really hard to trigger.
+>
+> Discussed with: kan
[...]
+> + if (usecount > 0 && vp->v_usecount == 0)
+> + printf("vinactive() won't be called for vp=%p\n", vp);
Hmm, maybe it should be:
if (usecount > 0 && vp->v_usecount == 0 && oweinact)
?
--
Pawel Jakub Dawidek http://www.wheel.pl
pjd@FreeBSD.org http://www.FreeBSD.org
FreeBSD committer Am I Evil? Yes, I Am!
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (FreeBSD)
iD8DBQFDtGvcForvXbEpPzQRAvZeAKDkJf1ZPV4lyOJaR8cy5lJOCO1/uwCggLlH
Qgx6LvPd8Qx1PSthUfvK80U=
=w4C/
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051229230604.GA22411>