Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 9 Dec 2017 15:47:27 +0000 (UTC)
From:      Mark Johnston <markj@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r326732 - head/sys/vm
Message-ID:  <201712091547.vB9FlRtp096929@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: markj
Date: Sat Dec  9 15:47:26 2017
New Revision: 326732
URL: https://svnweb.freebsd.org/changeset/base/326732

Log:
  Fix the act_scan_laundry_weight mechanism.
  
  r292392 modified the active queue scan to weigh clean pages differently
  from dirty pages when attempting to meet the inactive queue target. When
  r306706 was merged into the PQ_LAUNDRY branch, this mechanism was
  broken. Fix it by scalaing the correct page shortage variable.
  
  Reviewed by:	alc, kib
  MFC after:	1 week
  Differential Revision:	https://reviews.freebsd.org/D13423

Modified:
  head/sys/vm/vm_pageout.c

Modified: head/sys/vm/vm_pageout.c
==============================================================================
--- head/sys/vm/vm_pageout.c	Sat Dec  9 15:44:30 2017	(r326731)
+++ head/sys/vm/vm_pageout.c	Sat Dec  9 15:47:26 2017	(r326732)
@@ -1393,7 +1393,7 @@ drop_page:
 	inactq_shortage = vm_cnt.v_inactive_target - (vm_cnt.v_inactive_count +
 	    vm_cnt.v_laundry_count / act_scan_laundry_weight) +
 	    vm_paging_target() + deficit + addl_page_shortage;
-	page_shortage *= act_scan_laundry_weight;
+	inactq_shortage *= act_scan_laundry_weight;
 
 	pq = &vmd->vmd_pagequeues[PQ_ACTIVE];
 	vm_pagequeue_lock(pq);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201712091547.vB9FlRtp096929>