Date: Wed, 15 Feb 2006 15:51:20 +0100 From: Markus Brueffer <markus@brueffer.de> To: freebsd-usb@freebsd.org Cc: freebsd-bluetooth@freebsd.org Subject: [Patch] Fix collection entry parsing in libusbhid Message-ID: <200602151551.27188.markus@brueffer.de>
index | next in thread | raw e-mail
[-- Attachment #1 --] Hi, here is a patch for libusbhid which fixes parsing of collection entries if the collection has only non-variable Input/Output/Feature entries: http://people.freebsd.org/~markus/bt/parse.c.diff The problem ist that the output of collection pages has to be deferred until the report id is known. Without the patch, deferred collection pages are only reported correctly if variable Input/Output/Feature entries are present. The effect can be seen here (output of the hid descriptor dump of a Logitech MX5000 keyboard using bthidcontrol): http://people.freebsd.org/~markus/bt/mx5000_before.txt http://people.freebsd.org/~markus/bt/mx5000_after.txt Furthermore I have removed the loop in REPORT_SAVED_COLL. If someone knows why it was there in the first place, please share your wisdom :) Third change is the removal of REPORT_SAVED_COLL if the end of a collection is reached. All collection entries should have been reported by then. Ok to commit? Markus -- Markus Brueffer | GPG-Key: http://people.FreeBSD.org/~markus/markus.asc markus@brueffer.de | FP: 3F9B EBE8 F290 E5CC 1447 8760 D48D 1072 78F8 A8D4 markus@FreeBSD.org | FreeBSD: The Power to Serve! [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQBD8z/v1I0Qcnj4qNQRAkjSAKDCBidrz0FyH8W6P16KEix76s5A0wCfXMlQ 9AOrEWxkT9hLGdKcoAAisRQ= =Q0xs -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200602151551.27188.markus>