Date: Sat, 19 Nov 2016 10:49:37 +0000 From: Andrew Turner <andrew@fubar.geek.nz> To: Olivier Houchard <cognet@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r308819 - in head/sys/arm: conf ti/omap4 ti/omap4/pandaboard ti/usb Message-ID: <20161119104937.5e1abea8@zapp> In-Reply-To: <201611190055.uAJ0tkN8075550@repo.freebsd.org> References: <201611190055.uAJ0tkN8075550@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 19 Nov 2016 00:55:46 +0000 (UTC)
Olivier Houchard <cognet@FreeBSD.org> wrote:
...
> @@ -265,6 +269,16 @@ omap_ehci_probe(device_t dev)
> if (!ofw_bus_is_compatible(dev, "ti,ehci-omap"))
> return (ENXIO);
>
> +#ifdef SOC_OMAP4
> + /*
> + * If we're running a Pandaboard, run Pandaboard-specific
> + * init code.
> + */
> + root = OF_finddevice("/");
> + if (fdt_is_compatible(root, "ti,omap4-panda"))
> + pandaboard_usb_hub_init();
> +#endif
Shouldn't this be in the attach function? It should also use
ofw_bus_node_is_compatible as I'm about to remove fdt_is_compatible.
Andrew
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20161119104937.5e1abea8>