Date: Thu, 10 Apr 2003 12:29:06 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: nate@root.org Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/an if_an.c if_an_isa.c if_an_pccard.c if_an_pci.c Message-ID: <20030410.122906.62350043.imp@bsdimp.com> In-Reply-To: <Pine.BSF.4.21.0304101114320.31875-100000@root.org> References: <20030410051257.D296537B408@hub.freebsd.org> <Pine.BSF.4.21.0304101114320.31875-100000@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <Pine.BSF.4.21.0304101114320.31875-100000@root.org>
Nate Lawson <nate@root.org> writes:
: > @@ -817,9 +806,11 @@
: > */
: > ether_ifattach(ifp, sc->arpcom.ac_enaddr);
: > callout_handle_init(&sc->an_stat_ch);
: > - AN_UNLOCK(sc);
: >
: > return(0);
: > +fail:;
: > + mtx_destroy(&sc->an_mtx);
: > + return(error);
: > }
: >
: > static void
:
: Extra ; after "fail:"
I feel that it isn't a mistake. A label labels a statement, and this
label labels a null statement on purpose in case the statements after
it disappear.
: > @@ -176,18 +176,26 @@
: > an_alloc_port(dev, sc->port_rid, AN_IOSIZ);
: > an_alloc_irq(dev, sc->irq_rid, 0);
:
: You should probably check the return values of these.
Yea. Likely. The old driver didn't check, so I don't bother to check
them myself.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030410.122906.62350043.imp>