Date: Thu, 31 Jan 2008 07:41:03 GMT From: Warner Losh <imp@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 134534 for review Message-ID: <200801310741.m0V7f3TI079732@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=134534 Change 134534 by imp@imp_lighthouse on 2008/01/31 07:40:11 Make sure that frame.h and regnum.h match. There were two registers defiend in regnum.h that weren't in frame.h, which meant we were overwriting the FPU part of the frame structure. Since we had CPU_NOFPU defined, this didn't matter... It is still a bug and the down side of doing things the juniper way in frame.h. It looks prettier elsewere... Affected files ... .. //depot/projects/mips2-jnpr/src/sys/mips/include/frame.h#4 edit .. //depot/projects/mips2-jnpr/src/sys/mips/include/regnum.h#4 edit Differences ... ==== //depot/projects/mips2-jnpr/src/sys/mips/include/frame.h#4 (text+ko) ==== @@ -79,8 +79,12 @@ /* * FREEBSD_DEVELOPERS_FIXME: * Include any other registers which are CPU-Specific and - * need to be part of the frame here + * need to be part of the frame here. + * + * Also, be sure this matches what is defined in regnum.h */ + register_t ic; /* RM7k and RM9k specific */ + register_t dummy; /* Alignment for 32-bit case */ /* From here and on, only saved user processes. */ @@ -117,6 +121,12 @@ f_register_t f30; f_register_t f31; register_t fsr; + + /* + * COP2 registers may need to be saved here based on the CPU, and those + * might need to be per process, or even for the kernel, so we need + * some thought here. + */ }; /* REVISIT */ ==== //depot/projects/mips2-jnpr/src/sys/mips/include/regnum.h#4 (text+ko) ==== @@ -48,7 +48,7 @@ /* * Location of the saved registers relative to ZERO. - * Usage is p->p_regs[XX]. + * This must match struct trapframe defined in frame.h exactly. */ #define ZERO 0 #define AST 1
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200801310741.m0V7f3TI079732>