Date: Thu, 15 May 2003 22:19:15 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: obrien@freebsd.org Cc: arch@freebsd.org Subject: Re: Moving the generation of foodevs.h to build time Message-ID: <20030515.221915.26535850.imp@bsdimp.com> In-Reply-To: <20030516041506.GA82545@dragon.nuxi.com> References: <20030516031317.GC38966@dragon.nuxi.com> <20030515.220304.68038616.imp@bsdimp.com> <20030516041506.GA82545@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <20030516041506.GA82545@dragon.nuxi.com>
"David O'Brien" <obrien@freebsd.org> writes:
: On Thu, May 15, 2003 at 10:03:04PM -0600, M. Warner Losh wrote:
: > In message: <20030516031317.GC38966@dragon.nuxi.com>
: > "David O'Brien" <obrien@freebsd.org> writes:
: > : On Tue, May 13, 2003 at 12:18:15AM -0600, M. Warner Losh wrote:
: > : > OK. Here's a start at moving it. First, we have to move
: > : > devlist2h.awk out of tools back to dev/mii/devlist2h.awk. It
: > : > shouldn't be in tool if it only generates MII code,
: > :
: > : Why shouldn't it be a tool if it only generates MII code?
: > : Can't we just rename all the devlist2h.awk's to
: > : @/tools/${_dev}-devlist2h.awk?
: >
: > I can paint this bikeshed either way. tools/devlist2h.awk isn't the
: > right name/place for it. I don't care if we do a
: > ${_dev}-devlist2h.awk or dev/${_dev}/devlist2h.awk. Arguments can be
: > made either way.
:
: Should we commit this patch (in some form) for 5.1 or after 5.1?
I'm not sure that we should rush it into 5.1 at this point. There's
nothing really gained by the patch, nor does it really fix any bugs,
yet it introduces a risk of breaking some case that works now. Given
the problems we've had building the release, I think it would be
prudent to wait. Nothing is lost by waiting.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030515.221915.26535850.imp>