Date: Wed, 18 Feb 2004 21:02:55 +0200 From: Ruslan Ermilov <ru@FreeBSD.org> To: "Andrey A. Chernov" <ache@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/gnu/usr.bin/binutils/gasp Makefile src/gnu/usr.bin/binutils/gdb Makefile src/gnu/usr.bin/cvs/cvs Makefile src/gnu/usr.bin/cvs/lib Makefile src/gnu/usr.bin/cvs/libdiff Makefile src/gnu/usr.bin/diff Makefile src/gnu/usr.bin/grep Makefile Message-ID: <20040218190255.GB1578@ip.net.ua> In-Reply-To: <200402170538.i1H5cjQa010622@repoman.freebsd.org> References: <200402170538.i1H5cjQa010622@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Mon, Feb 16, 2004 at 09:38:45PM -0800, Andrey A. Chernov wrote:
> ache 2004/02/16 21:38:45 PST
>
> FreeBSD src repository
>
> Modified files:
> gnu/usr.bin/binutils/gasp Makefile
> gnu/usr.bin/binutils/gdb Makefile
> gnu/usr.bin/cvs/cvs Makefile
> gnu/usr.bin/cvs/lib Makefile
> gnu/usr.bin/cvs/libdiff Makefile
> gnu/usr.bin/diff Makefile
> gnu/usr.bin/grep Makefile
> Log:
> Oops, use -I${DESTDIR}/usr/include/gnu instead of ... /../../include/gnu
>
> Revision Changes Path
> 1.14 +1 -1 src/gnu/usr.bin/binutils/gasp/Makefile
> 1.75 +1 -1 src/gnu/usr.bin/binutils/gdb/Makefile
> 1.44 +1 -1 src/gnu/usr.bin/cvs/cvs/Makefile
> 1.25 +1 -2 src/gnu/usr.bin/cvs/lib/Makefile
> 1.8 +1 -2 src/gnu/usr.bin/cvs/libdiff/Makefile
> 1.16 +1 -1 src/gnu/usr.bin/diff/Makefile
> 1.28 +1 -1 src/gnu/usr.bin/grep/Makefile
>
This is bogus. The correct way would be to fix #include's to
spell ``#include <gnu/regex.h>'', but this will be considered
evil as it will take lot of files off their vendor branches.
What was wrong with ${.CURDIR}/.../include/gnu, except
misspelling the number of ".."'s in some cases?
I've been slowly working towards removing all instances of
-I${DESTDIR}/usr/include/... in the src/ makefiles. Before
this commit, there were only a few makefiles with
-I${DESTDIR}/usr/include/rpcsvc, but RPC code is known to be
a nightmare to deal with.
Cheers,
--
Ruslan Ermilov
FreeBSD committer
ru@FreeBSD.org
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)
iD8DBQFAM7bfUkv4P6juNwoRAi+LAJ4y5BlP4M0NS7kTcAflkkGh6DoQbQCfSaU7
bP/l1WYO01Qcx/Ac07vpKXc=
=qUfv
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040218190255.GB1578>