Date: Fri, 6 Jun 2025 20:25:14 GMT From: Doug Moore <dougm@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 7908b5df1abd - main - pctrie_lookup_node: assume parent_out != NULL Message-ID: <202506062025.556KPENC017937@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by dougm: URL: https://cgit.FreeBSD.org/src/commit/?id=7908b5df1abdb3cf9aac0560401a718bff3e304a commit 7908b5df1abdb3cf9aac0560401a718bff3e304a Author: Doug Moore <dougm@FreeBSD.org> AuthorDate: 2025-06-06 20:24:01 +0000 Commit: Doug Moore <dougm@FreeBSD.org> CommitDate: 2025-06-06 20:24:01 +0000 pctrie_lookup_node: assume parent_out != NULL Since NULL is never passed as the parent_out parameter to _pctrie_lookup_node, stop making the assignment to *parent_out check parent_out for NULL first. Reported by: alc Reviewed by: alc Differential Revision: https://reviews.freebsd.org/D50729 --- sys/kern/subr_pctrie.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sys/kern/subr_pctrie.c b/sys/kern/subr_pctrie.c index 676e3595316a..cb813cfbd847 100644 --- a/sys/kern/subr_pctrie.c +++ b/sys/kern/subr_pctrie.c @@ -514,8 +514,7 @@ _pctrie_lookup_node(struct pctrie *ptree, struct pctrie_node *node, parent = node; node = pctrie_node_load(&node->pn_child[slot], smr, access); } - if (parent_out != NULL) - *parent_out = parent; + *parent_out = parent; return (node); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202506062025.556KPENC017937>